-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Fix flaky Postgres tests #8613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for opening this issue!
|
@dplewis not sure if that helps with fixing the flaky tests for Postgres, but since we disabled test randomization, there seems to be a recurring pattern of Postgres failing exactly like this: https://github.com/parse-community/parse-server/actions/runs/9973005229/job/27557477165?pr=9209 |
Is this for a specific Postgres version? Can I pick up this bounty? |
I believe I have seen the issue always occurring for the same Postgres version since we disabled the test randomization. The issue has been created for all flaky tests that are specific to Postgres, but I'm unsure how vast that is, now that the randomizer is off. I guess if you could fix the flaky test from the log above we can close this issue and pay out the bounty, as w/o randomizer it seems to be the only flaky test. |
This test has always been flaky since the introduction of transactions. I would have fixed it years ago if I knew how it worked. Probably @davimacedo knows how to fix it. Also this isn't postgres specific either this can fail for mongo as well. ![]() |
Interestingly, since we disabled the randomizer it seems to be only that specific Postgres version where it fails. |
🎉 This change has been released in version 7.3.0-alpha.3 |
🎉 This change has been released in version 7.3.0-beta.1 |
🎉 This change has been released in version 7.3.0 |
New Issue Checklist
Issue Description
The flaky Postgres tests are currently the most significant bottleneck when it comes to merging PRs:
While there were other CI/CD related bottlenecks in the past, they have largely been removed over time so that this issue became now the most impactful one.
Solution
Fix the flakiness.
The text was updated successfully, but these errors were encountered: