Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password reset link not working for usernames with "+" #993

Closed
3 tasks done
sjincho opened this issue Mar 12, 2016 · 1 comment · Fixed by #1001
Closed
3 tasks done

Password reset link not working for usernames with "+" #993

sjincho opened this issue Mar 12, 2016 · 1 comment · Fixed by #1001

Comments

@sjincho
Copy link

sjincho commented Mar 12, 2016

Make sure these boxes are checked before submitting your issue -- thanks for reporting issues back to Parse Server!

Environment Setup

Ran https://github.com/ParsePlatform/parse-server-example with changes for email adapter on AWS Elastic Beanstalk.

Steps to reproduce

  1. Request for password reset for any existing user with username that contains "+".
  2. In the password reset email, when the user click the link, "+" gets translated into space.

Logs/Trace

n/a

https://github.com/ParsePlatform/parse-server/blob/master/views/choose_password#L152
https://github.com/ParsePlatform/parse-server/blob/master/views/choose_password#L163

Seems choose_password is changing '+' in usernames to ' '. If I change ' ' back to '+' using the browser's dom inspector, changing password works.

@gfosco
Copy link
Contributor

gfosco commented Mar 17, 2016

Will be fixed very soon by #1001.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants