Skip to content

Commit 84cf211

Browse files
committed
Check if the data is null when get platform arn
1 parent 780afbc commit 84cf211

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

spec/SNSPushAdapter.spec.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,24 @@ describe('SNSPushAdapter', () => {
158158
});
159159
});
160160

161+
it('errors exchanging device tokens for an Amazon Resource Number (ARN) because data is null', (done) => {
162+
163+
// Mock out Amazon SNS token exchange
164+
var snsSender = jasmine.createSpyObj('sns', ['createPlatformEndpoint']);
165+
snsPushAdapter.sns = snsSender;
166+
167+
snsSender.createPlatformEndpoint.and.callFake(function(object, callback) {
168+
callback("error", null);
169+
});
170+
171+
var promise = snsPushAdapter.exchangeTokenPromise(makeDevice("androidToken"), "GCM_ID");
172+
173+
promise.catch(function() {
174+
expect(snsSender.createPlatformEndpoint).toHaveBeenCalled();
175+
done();
176+
});
177+
});
178+
161179
it('errors exchanging device tokens for an Amazon Resource Number (ARN)', (done) => {
162180

163181
// Mock out Amazon SNS token exchange

src/SNSPushAdapter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ SNSPushAdapter.prototype.exchangeTokenPromise = function (device, platformARN) {
173173
return new Parse.Promise((resolve, reject) => {
174174

175175
this.getPlatformArn(device, platformARN, (err, data) => {
176-
if (data.EndpointArn) {
176+
if (data !== null && data.EndpointArn) {
177177
resolve({device: device, arn: data.EndpointArn});
178178
}
179179
else

0 commit comments

Comments
 (0)