clippy suggestions

Author: nikhilsinhaparseable

src/static_schema.rs

@@ -56,8 +56,6 @@ pub struct Fields {
     metadata: HashMap<String, String>,
 }
 
-#[derive(Default, Debug, Clone, PartialEq, Serialize, Deserialize)]
-pub struct Metadata {}
 pub fn convert_static_schema_to_arrow_schema(
     static_schema: StaticSchema,
     time_partition: &str,

src/storage/azure_blob.rs

@@ -426,7 +426,7 @@ impl BlobStore {
 
             // let mut upload_parts = Vec::new();
 
-            let has_final_partial_part = total_size % MIN_MULTIPART_UPLOAD_SIZE > 0;
+            let has_final_partial_part = !total_size.is_multiple_of(MIN_MULTIPART_UPLOAD_SIZE);
             let num_full_parts = total_size / MIN_MULTIPART_UPLOAD_SIZE;
             let total_parts = num_full_parts + if has_final_partial_part { 1 } else { 0 };
 

src/storage/gcs.rs

@@ -367,7 +367,7 @@ impl Gcs {
             let mut data = Vec::new();
             file.read_to_end(&mut data).await?;
 
-            let has_final_partial_part = total_size % MIN_MULTIPART_UPLOAD_SIZE > 0;
+            let has_final_partial_part = !total_size.is_multiple_of(MIN_MULTIPART_UPLOAD_SIZE);
             let num_full_parts = total_size / MIN_MULTIPART_UPLOAD_SIZE;
             let total_parts = num_full_parts + if has_final_partial_part { 1 } else { 0 };
 

src/storage/localfs.rs

@@ -239,7 +239,7 @@ impl ObjectStorage for LocalFS {
     async fn get_objects(
         &self,
         base_path: Option<&RelativePath>,
-        filter_func: Box<(dyn Fn(String) -> bool + std::marker::Send + 'static)>,
+        filter_func: Box<dyn Fn(String) -> bool + std::marker::Send + 'static>,
     ) -> Result<Vec<Bytes>, ObjectStorageError> {
         let prefix = if let Some(path) = base_path {
             path.to_path(&self.root)
@@ -278,6 +278,18 @@ impl ObjectStorage for LocalFS {
             let file_result = fs::read(entry.path()).await;
             match file_result {
                 Ok(file) => {
+                    // Record total files scanned
+                    increment_files_scanned_in_object_store_calls_by_date(
+                        "localfs",
+                        "GET",
+                        1,
+                        &Utc::now().date_naive().to_string(),
+                    );
+                    increment_object_store_calls_by_date(
+                        "localfs",
+                        "GET",
+                        &Utc::now().date_naive().to_string(),
+                    );
                     res.push(file.into());
                 }
                 Err(err) => {
@@ -286,16 +298,15 @@ impl ObjectStorage for LocalFS {
             }
         }
 
-        // Record total files scanned
         increment_files_scanned_in_object_store_calls_by_date(
             "localfs",
-            "GET",
+            "LIST",
             files_scanned as u64,
             &Utc::now().date_naive().to_string(),
         );
         increment_object_store_calls_by_date(
             "localfs",
-            "GET",
+            "LIST",
             &Utc::now().date_naive().to_string(),
         );
 

src/storage/s3.rs

@@ -532,7 +532,7 @@ impl S3 {
 
             // let mut upload_parts = Vec::new();
 
-            let has_final_partial_part = total_size % MIN_MULTIPART_UPLOAD_SIZE > 0;
+            let has_final_partial_part = !total_size.is_multiple_of(MIN_MULTIPART_UPLOAD_SIZE);
             let num_full_parts = total_size / MIN_MULTIPART_UPLOAD_SIZE;
             let total_parts = num_full_parts + if has_final_partial_part { 1 } else { 0 };