Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash is only calculated on response body and not the extracted javascript #20

Open
parsiya opened this issue Jan 20, 2020 · 0 comments
Open
Assignees
Labels
brainstorming Brainstorming enhancement New feature or request

Comments

@parsiya
Copy link
Owner

parsiya commented Jan 20, 2020

This means the hash can only be used to detect if the responses are the same. In most cases, it's when we are requesting the same exact JavaScript file.

It should work on the extracted JavaScript which is what is fed into the beautify and eslint functions. This way we can detect chunks of Javascript that are embedded in pages.

Ideally, the extension should be able to detect chunks of JavaScript and populate the results if they are already seen. That said, it's going to be difficult because a page can have multiple chunks of embedded JavaScript and currently we concat all of them together and pass them to the functions.

@parsiya parsiya added enhancement New feature or request brainstorming Brainstorming labels Jan 20, 2020
@parsiya parsiya self-assigned this Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brainstorming Brainstorming enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant