-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix NPE when parsing null options used by conditions (fixes #133) #134
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
============================================
- Coverage 71.91% 71.90% -0.02%
Complexity 4354 4354
============================================
Files 479 479
Lines 15856 15856
Branches 2175 2175
============================================
- Hits 11403 11401 -2
- Misses 3571 3574 +3
+ Partials 882 881 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two areas that could be improved:
-
This change introduces a string literal "null" to manage code, which could be refined for maintainability.
-
The code should align with the surrounding code to ensure consistency.
A good reference point would be the following line of code just below your change:
} else if (!Objects.toString(options.get(key)).equals(value)) { // a=b |
…b#133) Signed-off-by: cs-cat <118669451+cs-cat@users.noreply.github.com>
Thanks for your suggestion. I have fixed the commit. @zhangt2333 |
fix NPE when parsing null options used by conditions (fixes #133)