Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NPE when parsing null options used by conditions (fixes #133) #134

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

cs-cat
Copy link
Contributor

@cs-cat cs-cat commented Dec 14, 2024

fix NPE when parsing null options used by conditions (fixes #133)

Copy link

github-actions bot commented Dec 14, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@cs-cat
Copy link
Contributor Author

cs-cat commented Dec 14, 2024

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Dec 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.90%. Comparing base (9eb966e) to head (27312c1).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #134      +/-   ##
============================================
- Coverage     71.91%   71.90%   -0.02%     
  Complexity     4354     4354              
============================================
  Files           479      479              
  Lines         15856    15856              
  Branches       2175     2175              
============================================
- Hits          11403    11401       -2     
- Misses         3571     3574       +3     
+ Partials        882      881       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zhangt2333 zhangt2333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two areas that could be improved:

  1. This change introduces a string literal "null" to manage code, which could be refined for maintainability.

  2. The code should align with the surrounding code to ensure consistency.

A good reference point would be the following line of code just below your change:

} else if (!Objects.toString(options.get(key)).equals(value)) { // a=b

…b#133)

Signed-off-by: cs-cat <118669451+cs-cat@users.noreply.github.com>
@cs-cat
Copy link
Contributor Author

cs-cat commented Dec 15, 2024

Thanks for your suggestion. I have fixed the commit. @zhangt2333

@cs-cat cs-cat requested a review from zhangt2333 December 15, 2024 03:17
@zhangt2333 zhangt2333 merged commit cf552a6 into pascal-lab:master Dec 15, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFG analysis with exceptions:null will cause NPE
3 participants