Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to change title of merge #87

Open
VildeBrobacke opened this issue Jun 5, 2020 · 7 comments
Open

Add option to change title of merge #87

VildeBrobacke opened this issue Jun 5, 2020 · 7 comments
Labels
bug Something isn't working

Comments

@VildeBrobacke
Copy link

Currently when automerging a PR that only has one commit, the title of the merge will be the title of that commit. While automerging a PR that has multiple commits the title of the merge will be the same as the title of the PR.

Using MERGE_COMMIT_MESSAGE the merge description can be changed, either having this also change the title of the merge, or having something like MERGE_COMMIT_TITLE would be great for consistency.

@pascalgn
Copy link
Owner

pascalgn commented Jun 5, 2020

Currently when automerging a PR that only has one commit, the title of the merge will be the title of that commit. While automerging a PR that has multiple commits the title of the merge will be the same as the title of the PR.

Which behaviour do you not like? The one with one commit or the one with multiple commits? Or rather, what's the behaviour you want? The MERGE_COMMIT_MESSAGE option will change title and description (title is always the first line of the commit message)

@VildeBrobacke
Copy link
Author

The behavior I would want is for the title to always be the title of the PR regardless of the amount of commits, and using MERGE_COMMIT_TITLE does not seem to let me do this.

On a PR with only 1 commit;
MERGE_COMMIT_MESSAGE: "{pullRequest.title} (#{pullRequest.number})\n{pullRequest.body}"
gives me this result:
image

Where instead I would expect this result:
image

@VildeBrobacke
Copy link
Author

@pascalgn Bump

@pascalgn
Copy link
Owner

Sorry for not getting back to you sooner! This should actually be working already, did you try setting MERGE_COMMIT_MESSAGE: "pull-request-title"?

@VildeBrobacke
Copy link
Author

It does not seem to be giving the result I'm after
image

From these results it seems to me that MERGE_COMMIT_MESSAGE doesn't affect the actual title but rather only the description of the merge message

@VildeBrobacke
Copy link
Author

@pascalgn bump

@pascalgn pascalgn added the bug Something isn't working label Nov 17, 2021
@pascalgn
Copy link
Owner

I don't use this feature myself, so I won't have time to look into this. But if you create a PR, I will look at it as soon as possible! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants