Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Merge Fails if workflow applied required label #97

Closed
TGTGamer opened this issue Jul 19, 2020 · 4 comments
Closed

bug: Merge Fails if workflow applied required label #97

TGTGamer opened this issue Jul 19, 2020 · 4 comments

Comments

@TGTGamer
Copy link

TGTGamer commented Jul 19, 2020

When using auto merge in the same workflow as something like actions/labeler the job fails to merge due to required label missing: automerge.

Workflow link: https://github.com/TGTGamer/.github/blob/b4e1a53e7b5faa73d25b7b25a93fd1037d100bd4/.github/workflows/pull.yml#L150
Failed job link: https://github.com/TGTGamer/.github/runs/887396777
Valid pull request which failed: Resnovas/workflow-mastermind#49

Console Output:

INFO  Event name: pull_request
INFO  Skipping PR update, required label missing: automerge
INFO  Skipping PR merge, required label missing: automerge

#78 -- might be a fix if merged and tested

@ryandy
Copy link

ryandy commented Jul 24, 2020

Similarly, the action's knowledge of PR labels can be out-of-date if the action is performed at the end of a multi-job workflow. For example, I'd like to run automerge-action after a series of build/test jobs that take about 10 minutes. If someone manually adds the automerge label during that time, automerge-action won't know, and will act based on the state of PR labels from when the workflow began.

I agree that #78 seems to be the fix. I tried it out locally and it worked for my use case. @pascalgn any plans to move forward with that PR?

@pascalgn
Copy link
Owner

I just merged #78! 👍

@ryandy
Copy link

ryandy commented Jul 26, 2020

Great, thanks!

@pascalgn
Copy link
Owner

pascalgn commented Aug 2, 2020

I think this is fixed now. However, feel free to reopen this or create a new issue if you disagree or if there are any other problems! 👍

@pascalgn pascalgn closed this as completed Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants