Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Register.rotate() #628

Closed
HGSilveri opened this issue Dec 29, 2023 · 0 comments · Fixed by #639
Closed

Deprecate Register.rotate() #628

HGSilveri opened this issue Dec 29, 2023 · 0 comments · Fixed by #639
Assignees
@HGSilveri
Labels
good first issue Good for newcomers
Milestone
v0.17 Release

Comments

@HGSilveri
Copy link
Collaborator

Register.rotate() is the only method that changes the register instance in-place. which is a potentially problematic behaviour. I propose we deprecate it and create a new method (Register.rotated()) that instead creates a new register object with the rotated coordinates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HGSilveri HGSilveri

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v0.17 Release
Development

Successfully merging a pull request may close this issue.

Replace Register.rotate() with Register.rotated() pasqal-io/Pulser
1 participant
@HGSilveri