Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement depolarizing and dephasing operations with projectors #691

Closed
a-corni opened this issue Jun 6, 2024 · 3 comments · Fixed by #715
Closed

Implement depolarizing and dephasing operations with projectors #691

a-corni opened this issue Jun 6, 2024 · 3 comments · Fixed by #715
Assignees
Milestone

Comments

@a-corni
Copy link
Collaborator

a-corni commented Jun 6, 2024

Currently, depolarizing and dephasing operations are defined in pulser_simulation/hamiltonian.py/Hamiltonian._build_collapse_operators using qutip.sigmax/y/z(). It would be better to define them with projectors sigma_{a}{b} with a, b in [r, g, h].

@HGSilveri HGSilveri added this to the Pulser v1 milestone Jun 7, 2024
@HGSilveri HGSilveri self-assigned this Jul 18, 2024
@HGSilveri
Copy link
Collaborator

I started working on this but now I'm wondering if it actually makes sense to do... Can you remind me of the motivation behind this suggestion?
Doing this will complicate the code (we have to define sigma_x/y/z for each basis) and I'm not sure we gain much from it, since this is internal code where the Pulser convention is well established and consistent.
So, my question is: do we really need this?

@a-corni
Copy link
Collaborator Author

a-corni commented Jul 22, 2024

That was to enable the definition of "depolarizing"/"dephasing" channels with the "leakage" noise option.
At first glance, I don't see why it would make it harder... Why don't we define sigma_gg - sigma_rr for dephasing_rate, sigma_gg - sigma_hh for hyperfine_dephasing_rate ? (Is this wrong with leakage noise ?)
I don't know how you would do it for depolarizing however...

@HGSilveri
Copy link
Collaborator

It's not harder, just more verbose for no reason I could remember... If you need it, that's good enough for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants