-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Adding digital noise #34
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @chMoussa thank you for this. Two points that puzzle me: 1) wouldn't be easier to have a DensityMatrix
type to be queried for instead of passing an argument all around ? It might not be idiomatic to Jax though. 2) Is there a need for NoiseProtocol
to be an empty tuple ? Other than that, minor quibbles around type updates (Tuple
-> tuple
) and few other points.
Hey @RolandMacDoland, |
Hey @RolandMacDoland , I managed to make it with a DensityMatrix class and a few singledispatch mathods to handle state vectors and density matrices differently. |
Closes #33 by:
NoiseInstance
with differentNoiseType
values from where we can extract the krauss operators.NoiseInstance
apply
functions to handle noise and inputState
provided as a density matrix.api
functions to work with density matrices.sample
andexpectation
as they were redundant with theapi
's