Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eth Stamp Changes #2331

Closed
1 of 3 tasks
erichfi opened this issue Mar 25, 2024 · 6 comments · Fixed by #2390, passportxyz/passport-scorer#574, passportxyz/passport-scorer#575, #2414 or #2415
Closed
1 of 3 tasks

Eth Stamp Changes #2331

erichfi opened this issue Mar 25, 2024 · 6 comments · Fixed by #2390, passportxyz/passport-scorer#574, passportxyz/passport-scorer#575, #2414 or #2415
Assignees

Comments

@erichfi
Copy link
Collaborator

erichfi commented Mar 25, 2024

User Story:

As a Passport user focused on Ethereum (ETH) engagement, I need transparent, updated criteria for the ETH stamp that are easy to understand and follow. This will help me tailor my activities within the Ethereum ecosystem to improve my stamp score efficiently.

Acceptance Criteria

GIVEN I am aiming to improve my ETH stamp,
WHEN I explore the ETH stamp criteria on the Passport platform,
THEN I find detailed, refreshed criteria with explicit points thresholds, empowering me to grasp how my Ethereum activities influence my score accurately.

Product & Design Links:

[Placeholder for links to detailed model documentation and user guidance on the Eth stamp changes]

Tech Details:

The Data Team has meticulously prepared an update for the ETH stamp criteria, introducing quantifiable engagement levels for users. This revamp is designed to demystify the path to achieving or enhancing the ETH stamp by providing clear, measurable targets. The updated criteria are categorized into two main sections for clarity and ease of understanding:

  1. Engagement Milestones
    a. ETH Enthusiast: Marks the initiation of engagement within the Ethereum ecosystem. (INTERNAL: ETHScore > 50)
    b. ETH Advocate: Represents a higher level of commitment and activity. (INTERNAL: ETHScore > 75)
    c. ETH Maxi: Denotes exceptional involvement and dedication. (INTERNAL: ETHScore > 90)
  2. Your Ethereum Activity Metrics
    a. Spend more than 0.25 ETH on gas: Highlights significant financial engagement with the network.
    b. Execute over 100 transactions: Indicates a robust level of transactional activity.
    c. Active on over 50 distinct days: Showcases sustained interaction with Ethereum.

Open Questions:

  • What additional support or resources will be provided to users to help them understand and meet the new criteria?
  • What coordination between the Data and Eng Teams is needed to deploy the new model alongside the stamp update?
  • How will feedback from users be collected and used to iterate on the ETH stamp criteria updates?

Notes/Assumptions:

  • The update aims to enhance user satisfaction by making ETH stamp achievements more attainable and understandable.
  • Users are expected to respond positively to clear, actionable criteria, which should drive increased engagement with the Ethereum ecosystem.
@erichfi erichfi added this to Passport Mar 25, 2024
@erichfi erichfi converted this from a draft issue Mar 25, 2024
@nutrina
Copy link
Collaborator

nutrina commented Apr 9, 2024

Question:

  • does 2.c mean that the user needs to be active on 50 different days? Or that the age of the first transaction is greater that 50 days.

For #1 we shall have a V2 endpoint. When integrating the new stamps in Passport, we will start pulling data from V2 of the API.
In addition to that #2 stamps we, need API changes to return the:

  • amount spent on gas
  • number of transactions executed
  • number of active days / age of first activity?

Also we will need to extend the cache to store the data we have for #2

Question: does this interfere with the analytics API?

@erichfi
Copy link
Collaborator Author

erichfi commented Apr 9, 2024

Thanks for your insightful questions regarding the integration of the new ETH stamp criteria. Here are the clarifications and directions for moving forward:

  1. Activity Requirement Clarification: For the criterion labeled as "Active for over 50 days," we define this as the user needing to be active on 50 different days. This distinction aims to emphasize consistent engagement with the Ethereum network over time, rather than the elapsed time since the first transaction.

  2. Integration Approach & API Versioning:

  • Agreeing with your suggestion, transitioning to a V2 endpoint for integrating the new stamps into Passport is the best course of action. This will enable us to incorporate the updated criteria effectively while ensuring compatibility with existing data structures.
  • I'll coordinate with @NadjibBenlaldj to ensure smooth integration and to address any potential issues with the deployment of the new model alongside the stamp update.
  • Regarding the specific data points needed for the new criteria (amount spent on gas, number of transactions executed, number of active days), we'll ensure these are accommodated within the API changes. Nadjib's insights will be invaluable here.
  1. Cache Extension and Analytics API:
  • Extending the cache to store additional data for the updated criteria is noted and will be incorporated into our implementation plan.
  • As for the Analytics API, this update will necessitate a separate enhancement. With proper versioning, we should be able to integrate these changes without disrupting existing functionalities. The versioning strategy will allow us to maintain backward compatibility while rolling out new features.

@erichfi
Copy link
Collaborator Author

erichfi commented Apr 9, 2024

  • Let's also update Analytics API to the v2 endpoint
  • Clear the Eth Activity Cache

@erichfi
Copy link
Collaborator Author

erichfi commented Apr 9, 2024

5 Points

@nutrina nutrina moved this from Prioritized to In Progress (WIP) in Passport Apr 13, 2024
@nutrina nutrina self-assigned this Apr 13, 2024
@nutrina
Copy link
Collaborator

nutrina commented Apr 16, 2024

API for model return: {"data": {"gas_spent": 0.264346083984993, "n_days_active": 33.0, "n_transactions": 76.0, "human_probability": 100}, "meta": {"version": "v2", "Training_date": "2024/03/06"}}

@nutrina nutrina moved this from In Progress (WIP) to Prioritized in Passport Apr 16, 2024
@lucianHymer lucianHymer moved this from Prioritized to In Progress (WIP) in Passport Apr 16, 2024
@lucianHymer lucianHymer self-assigned this Apr 16, 2024
@lucianHymer
Copy link
Collaborator

Pending review

@lucianHymer lucianHymer moved this from In Progress (WIP) to Blocked in Passport Apr 17, 2024
@nutrina nutrina moved this from Blocked to In Progress (WIP) in Passport Apr 18, 2024
@nutrina nutrina moved this from In Progress (WIP) to Blocked in Passport Apr 18, 2024
@nutrina nutrina moved this from Blocked to In Progress (WIP) in Passport Apr 18, 2024
@nutrina nutrina closed this as completed Apr 18, 2024
@erichfi erichfi reopened this Apr 18, 2024
@lucianHymer lucianHymer moved this from In Progress (WIP) to Product/UX Review in Passport Apr 22, 2024
@erichfi erichfi moved this from Product/UX Review to Ready to Deploy in Passport Apr 22, 2024
@erichfi erichfi moved this from Ready to Deploy to Done in Passport Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment