Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review PR #2426 for Outdid Stamp Integration #2430

Closed
erichfi opened this issue Apr 29, 2024 · 3 comments · Fixed by #2468
Closed

Review PR #2426 for Outdid Stamp Integration #2430

erichfi opened this issue Apr 29, 2024 · 3 comments · Fixed by #2468
Assignees

Comments

@erichfi
Copy link
Collaborator

erichfi commented Apr 29, 2024

Description:
A detailed review is required for PR #2426 submitted by Outdid, which involves the integration of their stamps into the Passport ecosystem. This SPIKE aims to evaluate the completeness of the integration, ensure compatibility with our existing systems, highlight any additional work that may be necessary, and coordinate a meeting with an Outdid developer for an end-to-end walk-through.

Acceptance Criteria:

  1. Code Review: Evaluate the code changes in the PR to ensure they meet our coding standards and integrate seamlessly with the existing Passport codebase.
  2. Functionality Testing: Test the integration in a controlled environment to verify that the new stamps function as expected without disrupting existing functionality.
  3. Compatibility Check: Ensure that the changes are compatible with different versions of the ecosystem that might be affected, including mobile and web platforms.
  4. Security Assessment: Identify any potential security issues introduced by the new changes.
  5. Performance Impact: Assess any impact on performance or scalability introduced by the integration.
  6. Documentation Review: Check if the new integration is adequately documented, including updates to API docs and user guides if necessary.
  7. Schedule Developer Walk-Through: Coordinate with an Outdid developer to schedule a detailed walk-through of the integration process. This will help clarify any complex integration points and ensure both teams are aligned on the implementation.
  8. Identify Additional Tasks: List any additional tasks or modifications needed to complete the integration based on the findings from the review.

Resources:

  • Link to PR: GitHub PR #2426
  • Access to testing environments
  • Documentation related to Outdid’s stamps
  • Contact information for the Outdid development team

Timebox:
Total time allocated for this SPIKE is 8 hours.

Outcome:

  • A comprehensive review report outlining the findings, including any issues identified and recommendations for additional work required. Ensure that all observations are documented clearly to facilitate swift action on remaining tasks.
  • Confirm the meeting schedule with the Outdid developer and provide a summary of key points to discuss.
@erichfi erichfi added this to Passport Apr 29, 2024
@erichfi erichfi converted this from a draft issue Apr 29, 2024
@nutrina nutrina moved this from Prioritized to In Progress (WIP) in Passport May 17, 2024
@nutrina nutrina self-assigned this May 17, 2024
@nutrina
Copy link
Collaborator

nutrina commented May 17, 2024

@erichfi when pushing this out we also need to:

  1. assign a weight to the stamp
    • rescore the passports (This is only required if we also change other stamp weights)
  2. register the provider to the on-chain decoder

@nutrina nutrina linked a pull request May 17, 2024 that will close this issue
@nutrina nutrina moved this from In Progress (WIP) to Blocked in Passport May 20, 2024
@nutrina
Copy link
Collaborator

nutrina commented May 20, 2024

Waiting for an 👍 from dev + another set of eyes.

@nutrina
Copy link
Collaborator

nutrina commented May 20, 2024

@erichfi @lebraat we are missing the CTA / Learn More link here. Could you please provide us a link to use?
There does not seem to be a section in our knowledge base.

@nutrina nutrina moved this from Blocked to Ready to Deploy in Passport May 20, 2024
@erichfi erichfi moved this from Ready to Deploy to Done in Passport Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants