Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTC Staking Expiry and Missing Sidebar Details #2642

Closed
erichfi opened this issue Jun 26, 2024 · 3 comments · Fixed by #2643, passportxyz/passport-scorer#624 or #2657
Closed

GTC Staking Expiry and Missing Sidebar Details #2642

erichfi opened this issue Jun 26, 2024 · 3 comments · Fixed by #2643, passportxyz/passport-scorer#624 or #2657
Assignees

Comments

@erichfi
Copy link
Collaborator

erichfi commented Jun 26, 2024

Overview
When GTC staking expires, the user is prompted to verify. After verification, points are awarded, but the expiry status does not change. Additionally, the sidebar information is missing and does not display the expected details.

Steps To Reproduce

  1. Ensure you have an expired GTC Staking stamp.
  2. Go to the 'GTC Staking' section.
  3. Observe the 'expired' status notification.
  4. Click on the 'Verify' button.
  5. Notice the points awarded after verification.
  6. Observe that the expiry status remains unchanged.
  7. Check the sidebar for details and observe missing information.

Observed behavior

  • The staking status remains 'expired' even after re-verifying.
  • The sidebar does not display the expected details related to the GTC staking status.

Expected behavior

  • The expiry status should update and no longer show as 'expired' after re-verifying.
  • The sidebar should display all relevant details about the GTC staking status as it did previously.

Screenshots
NA

Additional context
NA

@erichfi erichfi added this to Passport Jun 26, 2024
@erichfi erichfi moved this to Prioritized in Passport Jun 26, 2024
@nutrina nutrina moved this from Prioritized to In Progress (WIP) in Passport Jun 27, 2024
@nutrina nutrina self-assigned this Jun 27, 2024
@nutrina nutrina linked a pull request Jun 27, 2024 that will close this issue
@nutrina
Copy link
Collaborator

nutrina commented Jul 1, 2024

I am not able to see any problem when checking the steps above. Point 6 and 7 work fine as f ar as I can tell (I have tested with github stamp on local).
@erichfi I would need to pair with you on this to check if the problem still exists ...

I did however notice other problems:

  1. expired cards are not shown when all stamps of the card are expired
  2. the points in the score and the weights returned can be out of sync, as they are read from different source. We should read the weights from the configured DB scorer instead of the settings to ensure consistency (even though they should be the same in the current mode we are operating)

I'll work to fix the 2 points.

@nutrina
Copy link
Collaborator

nutrina commented Jul 2, 2024

@erichfi
Copy link
Collaborator Author

erichfi commented Jul 2, 2024

Let's address the reverification issues as part of this issue: #2663

@erichfi erichfi moved this from Blocked to Code Complete in Passport Jul 2, 2024
@erichfi erichfi moved this from Code Complete to Ready to Deploy in Passport Jul 3, 2024
@erichfi erichfi moved this from Ready to Deploy to Done in Passport Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants