Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #2459 #2690

Open
nutrina opened this issue Jul 12, 2024 · 5 comments · Fixed by passportxyz/passport-scorer#633, passportxyz/passport-scorer#635 or passportxyz/passport-scorer#636
Open

Revert #2459 #2690

nutrina opened this issue Jul 12, 2024 · 5 comments · Fixed by passportxyz/passport-scorer#633, passportxyz/passport-scorer#635 or passportxyz/passport-scorer#636
Assignees
@nutrina

Comments

@nutrina
Copy link
Collaborator

nutrina commented Jul 12, 2024 •
edited
Loading

Given some open question on #2459 we should:

  • revert the related merges
  • fix making http request async
  • wait for open question + make required adjustments
@nutrina nutrina added this to Passport Jul 12, 2024
@nutrina nutrina converted this from a draft issue Jul 12, 2024
@nutrina nutrina self-assigned this Jul 12, 2024
@nutrina nutrina mentioned this issue Jul 12, 2024
Merged
@nutrina nutrina linked a pull request Jul 12, 2024 that will close this issue
2690 revert 2459 passportxyz/passport-scorer#633
Merged
@nutrina
Copy link
Collaborator Author

nutrina commented Jul 12, 2024

Have reverted the changes from #2459 so that releases are not blocked by this.
Fixes & adjustments are pending.

@nutrina nutrina mentioned this issue Jul 15, 2024
Merged
@nutrina nutrina linked a pull request Jul 15, 2024 that will close this issue
feat: WIP - reading results from multiple models asynchronuosly using… passportxyz/passport-scorer#635
Merged
@nutrina
Copy link
Collaborator Author

nutrina commented Jul 15, 2024

Have committed a POC on how to perform async queries from the handler.
Need to move that to the proper spot, and load model endpoints from settings.

@erichfi erichfi reopened this Jul 15, 2024
@nutrina
Copy link
Collaborator Author

nutrina commented Jul 15, 2024 •
edited
Loading

As per our discussion:

  • we will keep this in beta for now
  • we will add a new parameters to allow choosing model. What we support:
    • individual models
    • default value: ethereum
    • we do not allow choosing multiple wallets

@nutrina nutrina mentioned this issue Jul 17, 2024
Merged
@nutrina nutrina linked a pull request Jul 17, 2024 that will close this issue
fix: unquote query string parameter passportxyz/passport-scorer#636
Merged
@nutrina nutrina moved this from In Progress (WIP) to Blocked in Passport Jul 17, 2024
@nutrina
Copy link
Collaborator Author

nutrina commented Jul 17, 2024

Waiting on final review of changes.

@erichfi erichfi reopened this Jul 24, 2024
@erichfi erichfi moved this from Blocked to Prioritized in Passport Jul 24, 2024
@nutrina nutrina moved this from Prioritized to Product/UX Review in Passport Jul 26, 2024
@nutrina
Copy link
Collaborator Author

nutrina commented Jul 26, 2024

This is done and has already been released

@erichfi erichfi moved this from Product/UX Review to Ready to Deploy in Passport Jul 30, 2024
@erichfi erichfi moved this from Ready to Deploy to Done in Passport Jul 30, 2024
@erichfi erichfi removed this from Passport New Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nutrina nutrina

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nutrina @erichfi