Skip to content

Commit 6b5d25a

Browse files
committed
Preferences specs
1 parent e21867e commit 6b5d25a

File tree

4 files changed

+34
-40
lines changed

4 files changed

+34
-40
lines changed

patch_api/rest.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,14 @@ def __init__(self, configuration, pools_size=4, maxsize=None):
5757
# maxsize is the number of requests to host that are allowed in parallel # noqa: E501
5858
# Custom SSL certificates and client certificates: http://urllib3.readthedocs.io/en/latest/advanced-usage.html # noqa: E501
5959

60-
self.configuration = configuration
61-
6260
# cert_reqs
6361
if configuration.verify_ssl:
6462
cert_reqs = ssl.CERT_REQUIRED
6563
else:
6664
cert_reqs = ssl.CERT_NONE
6765

66+
self.configuration = configuration
67+
6868
# ca_certs
6969
if configuration.ssl_ca_cert:
7070
ca_certs = configuration.ssl_ca_cert
@@ -141,6 +141,7 @@ def request(self, method, url, query_params=None, headers=None,
141141

142142
post_params = post_params or {}
143143
headers = headers or {}
144+
144145
timeout = None
145146
if _request_timeout:
146147
if isinstance(_request_timeout, (int, ) if six.PY3 else (int, long)): # noqa: E501,F821
@@ -222,6 +223,11 @@ def request(self, method, url, query_params=None, headers=None,
222223
if _preload_content:
223224
r = RESTResponse(r)
224225

226+
# In the python 3, the response.data is bytes.
227+
# we need to decode it to string.
228+
if six.PY3:
229+
r.data = r.data.decode('utf8')
230+
225231
# log response body
226232
logger.debug("response body: %s", r.data)
227233

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
from setuptools import setup, find_packages # noqa: H301
1515

16-
NAME = "patch_api"
16+
NAME = "patch-api"
1717
VERSION = "1.0.0"
1818
# To install the library, run the following
1919
#

test-requirements.txt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
pytest~=4.6.7 # needed for python 2.7+3.4
2-
pytest-cov>=2.8.1
3-
pytest-randomly==1.2.3 # needed for python 2.7+3.4
1+
coverage>=4.0.3
2+
nose>=1.3.7
3+
pluggy>=0.3.1
4+
py>=1.4.31
5+
randomize>=0.13
46
factory_boy>=2.12.0

test/test_preferences_api.py

Lines changed: 20 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -34,47 +34,33 @@ def setUp(self):
3434
def tearDown(self):
3535
pass
3636

37-
# def test_delete_and_create_preference(self):
38-
# """Test case for create_preference
37+
def test_retrieve_preferences_and_preference(self):
38+
"""Test case for retrieve_preferences and retrieve_preference
3939
40-
# creates a project preference # noqa: E501
41-
# """
42-
# # Try to create the preference
43-
# try:
44-
# project_id = "pro_test_2b67b11a030b66e0a6dd61a56b49079a"
45-
46-
# create_preference_request = CreatePreferenceRequest(project_id=project_id)
47-
# preference = self.api.create_preference(create_preference_request)
48-
49-
# # Delete it if it exists
50-
# except ApiException as err:
51-
# print('err---------------->', err)
52-
# deleted_preference = self.api.delete_preference(id=project_id)
53-
# self.assertTrue(deleted_preference)
54-
55-
# self.assertTrue(preference)
56-
# self.assertEqual(preference.data.project_id, project_id)
57-
58-
59-
# def test_retrieve_preference(self):
60-
# """Test case for retrieve_preference
40+
creates a project preference # noqa: E501
41+
"""
42+
preferences = self.api.retrieve_preferences()
43+
self.assertTrue(isinstance(preferences.data, list))
6144

62-
# Retrieve the preference # noqa: E501
63-
# """
64-
# project_id = "pro_test_2b67b11a030b66e0a6dd61a56b49079a"
45+
preference_id = preferences.data[0].id
46+
preference = self.api.retrieve_preference(id=preference_id)
47+
self.assertTrue(preference)
6548

66-
# create_preference_request = CreatePreferenceRequest(project_id=project_id)
67-
# preference = self.api.create_preference(create_preference_request)
49+
def test_delete_and_create_preferences(self):
50+
"""Test case for create_preference and delete_preference
51+
"""
52+
project_id = "pro_test_0de1a59eed9ff8474e09077ddb3714b2"
53+
preferences = self.api.retrieve_preferences()
54+
preference_id = preferences.data[0].id
6855

69-
# preference = self.api.retrieve_preference()
56+
deleted_preference = self.api.delete_preference(id=preference_id)
7057

58+
self.assertTrue(deleted_preference)
7159

72-
def test_retrieve_preferences(self):
73-
"""Test case for retrieve_preferences
60+
create_preference_request = CreatePreferenceRequest(project_id=project_id)
61+
preference = self.api.create_preference(create_preference_request)
7462

75-
Retrieves a list of preferences # noqa: E501
76-
"""
77-
pass
63+
self.assertTrue(preference)
7864

7965

8066
if __name__ == '__main__':

0 commit comments

Comments
 (0)