Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check PHPCS rules for Generic Templating #110

Closed
DanielBadura opened this issue Dec 8, 2021 · 1 comment
Closed

Check PHPCS rules for Generic Templating #110

DanielBadura opened this issue Dec 8, 2021 · 1 comment

Comments

@DanielBadura
Copy link
Member

DanielBadura commented Dec 8, 2021 •
edited
Loading

We should check if we want this or not. I think it is good that phpcs is also checking this but i can understand that someone says that it shouldnt do that.

Originally posted by @DanielBadura in #106 (comment)
@DavidBadura DavidBadura added this to the 1.1.0 milestone Dec 9, 2021
@DavidBadura DavidBadura removed this from the 1.1.0 milestone Dec 16, 2021
@DanielBadura
Copy link
Member Author

I think we should close it. Since phpcs can never have enough information to get a real grasp on what's going on with the generic since it's only performing the check on single files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DavidBadura @DanielBadura