New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editDistance bug? #22

Open

zhaomingli007 opened this issue Jan 22, 2019 · 0 comments

zhaomingli007 commented Jan 22, 2019

scalgos/src/main/scala/com/github/pathikrit/scalgos/DynamicProgramming.scala

Line 146 in 9e99f73

    
           case (a, b) => (delete + f(a, b.tail)) min (insert + f(a.tail, b)) min (replace + f(a.tail, b.tail))

When call editDistance(List("c"),List("b"),2,1,5), the expected cost should be 3 (one deletion + one addition). Now it returns 2.

Probably it can be modified as below?

    case (a, b) => (delete + f(a.tail, b)) min (insert + f(a.tail, a.head :: b)) min (replace + f(a.tail, b.tail))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment