Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broaden "amount" #518

Open
pbuttigieg opened this issue Aug 16, 2022 · 2 comments
Open

broaden "amount" #518

pbuttigieg opened this issue Aug 16, 2022 · 2 comments

Comments

@pbuttigieg
Copy link
Contributor

pbuttigieg commented Aug 16, 2022

Currently this only allows for numbers of things that are parts of organisms. We'd like to use that in ontologies like ENVO, but it's currently overspecific due to PATO's history.

It's also very strange that it's under "qualitative" - the definition is decidedly quantitative, which suggests it should be relabelled #65

Perhaps the current class can be relabelled and a superclass that's a more inclusive notion of amounts can be added.

xref: EnvironmentOntology/envo#1346

xref #226

@pbuttigieg
Copy link
Contributor Author

In fact it's already being used more broadly (and technically incorrectly) by some of our editors (@kaiiam @cmungall may have insight there)

image

@kaiiam
Copy link
Contributor

kaiiam commented Aug 17, 2022

I'm not sure at the moment what the right thing to do with amount is other than work on it in PATO to make it more general?

Those amount of carbon or nitrogen in env material classes are confusing are they ratios or concentrations? I'd presume the latter if so the concentration classes should be used instead. We currently don't have a pattern for ratios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants