Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: patrick-kidger/jaxtyping
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.2.31
Choose a base ref
...
head repository: patrick-kidger/jaxtyping
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.2.32
Choose a head ref
  • 3 commits
  • 5 files changed
  • 1 contributor

Commits on Jul 1, 2024

  1. Improved localisation of errors to particular arguments.

    This commit does two things.
    
    First of all, it fixes a bug in which we forgot to add in default arguments when calling `_get_problem_arg`. This meant that in practice, if you had a default argument, then the very first argument would be what is reported.
    
    Second, it rearranges things into a couple of extra stack frames, for an easier debugging experience.
    - When looking at the main error message, this will now occur on the line that actually raised it, and not the `finally: pop_stack_memo()` line.
    - The argument-specific `_get_problem_arg` error is what is now attached as the cause, rather than the overall failure of the whole typechecking.
    patrick-kidger committed Jul 1, 2024
    Copy the full SHA
    6236167 View commit details

Commits on Jul 2, 2024

  1. Copy the full SHA
    91cfc9b View commit details

Commits on Jul 12, 2024

  1. Version bump

    patrick-kidger committed Jul 12, 2024
    Copy the full SHA
    f7c57c3 View commit details
Loading