Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Awesome 6 Duotone glyphs not properly extracted #63

Open
Moustachos opened this issue May 6, 2022 · 4 comments
Open

Font Awesome 6 Duotone glyphs not properly extracted #63

Moustachos opened this issue May 6, 2022 · 4 comments

Comments

@Moustachos
Copy link
Contributor

Hello Patrick,

Font Awesome Duotone icons are made up of 2 glyphs, 1 for ::before & 1 for ::after.

In V5, ::after code was the same as ::before prefixed with 10, example: https://fontawesome.com/v5/icons/spinner-third?s=duotone

In V6, ::after is a doubled ::before code, example: https://fontawesome.com/icons/spinner-third?s=duotone

::before glyph is still extracted properly, but ::after glyph is missing in output file.

Any idea on how to approach / fix this?

Thanks :)

@Moustachos
Copy link
Contributor Author

@patrickhulce could you take a look at this one when you got some time?

Apparently they're using ligatures to handle Duotone glyphs since version 6.

@patrickhulce
Copy link
Owner

Ah shoot, thanks for the ping @Moustachos. Yeah we'd have to adjust our glyph set to handle this multi-glyph case. I don't really have the bandwidth to investigate a fix right now but if anyone is interested in contributing, this would be a great way to have an impact.

@patrickhulce
Copy link
Owner

The fix would probably look similar to the multi-byte unicode fix PR (e0743ba)

@Moustachos
Copy link
Contributor Author

Moustachos commented Jun 15, 2022

Thanks for the update :)

I tried to look into it myself but sadly I don't get how to work with ligatures.

So yeah, any help would be welcome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants