Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTS: imported components show as unused #109

Closed
SanderKnauff opened this issue Dec 30, 2023 · 2 comments · Fixed by #115
Closed

GTS: imported components show as unused #109

SanderKnauff opened this issue Dec 30, 2023 · 2 comments · Fixed by #115

Comments

@SanderKnauff
Copy link
Contributor

SanderKnauff commented Dec 30, 2023

Description

When importing from a GTS file, IntelliJ reports the import as unresolvable.
This also causes the imported values to not have their types known.

Steps to Reproduce

  1. Clone https://github.com/universal-ember/ember-primitives
  2. Open ./ember-primitives/src/components/popover.gts

Expected behavior:

The import import { Velcro } from 'ember-velcro'; should show as used, as it is used in the component template at line 216.

Actual behavior:

The import import { Velcro } from 'ember-velcro'; shows as unused

Reproduces how often:

This can always be reproduced

Versions

IntelliJ IDEA 2023.3.2 (Ultimate Edition)
Build #IU-233.13135.103, built on December 20, 2023

Plugin version: 2023.3.1

Additional Information

The fields on the |velcro| value yielded from the <Velcro> component also are unresolved, could this be related to the issue itself or should this be considered to be another bug?

@patricklx
Copy link
Owner

patricklx commented Dec 30, 2023

It is probably related. Or it's an issue with intellij lsp not giving me any references anymore...
When you ctrl+click on the <Velcro tag, does it jump to the definition or import?

@SanderKnauff
Copy link
Contributor Author

It is probably related. Or it's an issue with intellij lsp not giving me any references anymore... When you ctrl+click on the <Velcro tag, does it jump to the definition or import?

When I ctrl + click on the tag, the editor jumps to the import. That part seems to be working correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants