Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies don't get updated if the version is delegated #14

Closed
cwrau opened this issue Dec 6, 2018 · 9 comments
Closed

Dependencies don't get updated if the version is delegated #14

cwrau opened this issue Dec 6, 2018 · 9 comments
Labels
bug Something isn't working

Comments

@cwrau
Copy link

cwrau commented Dec 6, 2018

I have the following build.gradle.kts:

val junitVersion: String by project

dependencies {
	testRuntimeOnly("org.junit.jupiter", "junit-jupiter-engine", junitVersion)
}

and my gradle.properties:

junitVersion=5.3.1

If I run ./gradlew dependencyUpdates I can see that there is an update for junit to 5.3.2.

But if I run ./gradlew useLatestVersions the gradle.properties does not get updated.

@usr42
Copy link
Contributor

usr42 commented Dec 6, 2018

Which version of the plugin do you use?

@cwrau
Copy link
Author

cwrau commented Dec 6, 2018

I'm using the following versions:

     id("se.patrikerdes.use-latest-versions") version "0.2.7"
     id("com.github.ben-manes.versions") version "0.20.0"

@patrikerdes patrikerdes added the bug Something isn't working label Dec 6, 2018
@usr42
Copy link
Contributor

usr42 commented Feb 18, 2019

@cwrau I can reproduce the issue, but it is not related to the delegete.
It happens because you use testRuntimeOnly not with the dependencyNotation (testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:$junitVersion"), but with explicit group, name and version without named parameters.
This doesn't seem to be supported yet.

I will write some more test cases for the different possibilities to specify the dependencies with the Kotlin DSL and will open a PR to add this functionality.

@patrikerdes
Copy link
Owner

@usr42 thanks, all contributions are very welcome

@usr42
Copy link
Contributor

usr42 commented Feb 19, 2019

@cwrau This should be fixed now

@cwrau
Copy link
Author

cwrau commented Feb 19, 2019

Amazing!
When can I expect a release?
Or is it automagically deployed?

@usr42
Copy link
Contributor

usr42 commented Feb 19, 2019

It's not automatically deployed, so we have to wait for a release.
@patrikerdes If you need any help, please let me know. Are for example some Readme adaptation needed?

@patrikerdes
Copy link
Owner

It has been released as 0.2.8

@cwrau
Copy link
Author

cwrau commented Feb 20, 2019

Thank you for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants