Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in representation of object in 3.9.6 #399

Closed
bespokebob opened this issue Feb 9, 2022 · 2 comments
Closed

Change in representation of object in 3.9.6 #399

bespokebob opened this issue Feb 9, 2022 · 2 comments

Comments

@bespokebob
Copy link
Contributor

I haven't figured out what's going on with this change, but it's odd, and it's making some of my tests fail.

const { NodeVM } = require('vm2')

const vm = new NodeVM({})

const result = vm.run('{}', 'vm.js')

console.log(result)

Output on 3.9.5:

{}

Output on 3.9.6:

Object {}
@XmiliaH
Copy link
Collaborator

XmiliaH commented Feb 9, 2022

Thanks, this is an oversight from me. I set the Symbol.toStringTag for Objects in the Proxy which should not happen.

@XmiliaH
Copy link
Collaborator

XmiliaH commented Feb 10, 2022

Should be fixed in v3.9.7

@XmiliaH XmiliaH closed this as completed Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants