Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate @hadl/patternlab-plugin-pattern-wrap into core #1433

Merged
merged 5 commits into from
Sep 25, 2022

Conversation

hadl
Copy link
Contributor

@hadl hadl commented Apr 10, 2022

Closes #1432

@JosefBredereck
Copy link
Contributor

@hadl thank you for your contribution. 🚀 I would like to request some tests for this change.
I will try to look into the changes after holidays.

@hadl
Copy link
Contributor Author

hadl commented Apr 14, 2022

@JosefBredereck great, thanks.

i would suggest to do the documentation etc if this is ready to merge and no further changes need to be done.

@JosefBredereck
Copy link
Contributor

@JosefBredereck great, thanks.

i would suggest to do the documentation etc if this is ready to merge and no further changes need to be done.

Do you mean you want to open another PR or within that one?

@hadl
Copy link
Contributor Author

hadl commented Sep 25, 2022

@JosefBredereck test and docs added. Hope everything fits your needs.

There was broken link in packages/docs/src/docs/advanced-config-options.md:213 - this is fixed too

@JosefBredereck JosefBredereck merged commit 414e038 into pattern-lab:dev Sep 25, 2022
@hadl hadl deleted the feature/pattern-wrap-classes branch January 15, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration of @hadl/patternlab-plugin-pattern-wrap into core
2 participants