Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: twig logo is rendered as "NaN" #1434

Merged

Conversation

hadl
Copy link
Contributor

@hadl hadl commented Apr 10, 2022

Closes: #1407

Summary of changes:

  • fix access for links in twig with hyphen in array key

@hadl hadl force-pushed the feature/1407-fix-twig-logo-link branch from 3ce39f7 to 0fa0cf8 Compare April 10, 2022 14:47
@mfranzke
Copy link
Contributor

@JosefBredereck looks good to me, fixed the problem on a localhost installation retest.

@JosefBredereck JosefBredereck merged commit ab6b133 into pattern-lab:dev Sep 21, 2022
@JosefBredereck
Copy link
Contributor

PR was released with v5.16.3

@hadl hadl deleted the feature/1407-fix-twig-logo-link branch January 15, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twig: Logo links rendered as "NaN"
3 participants