fix: subitems menu height restricted only for horizontal mode #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosefBredereck
approved these changes
Mar 12, 2023
JosefBredereck
deleted the
1491-subitems-would-get-cropped-or-disappear-on-vertical-navigation
branch
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1491
Summary of changes:
This is related to a change out of https://github.com/pattern-lab/patternlab-node/pull/1102/files#diff-c6ea82df3775776f3aef432cf591cbc9ee94c10a98e9471ec4567d5ea51efe74R22-R26
As this one was most likely meant for horizontal nav display, in which it makes good sense, but wasn't restricted to this one, it's now letting longer items or lists of opened subitems getting cropped of or even disappear.