Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl+shift+0 does not set viewport to 320px per documentation #201

Closed
bmuenzenmeyer opened this issue Dec 3, 2015 · 5 comments
Closed

Comments

@bmuenzenmeyer
Copy link
Member

Instead, it sets to the first MQ as ctrl+shift+1 is supposed to do.
reference: http://patternlab.io/docs/advanced-keyboard-shortcuts.html

@bmuenzenmeyer
Copy link
Member Author

Scratch that initial report. I debugged this and the command's don't even reach the handlers. Confirmed this is an issue in Chrome, Firefox, Edge and Opera, with local code and demo.patternlab.io

Chrome does map this command too: https://support.google.com/chromebook/answer/183101?hl=en
Other commands look masked in Firefox too https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly

Going to document this is known issue and move on for now.

@bmuenzenmeyer
Copy link
Member Author

@bmuenzenmeyer
Copy link
Member Author

@dmolsen have you experienced this? I couldn't find an issue on any of your repos.

@dmolsen
Copy link
Member

dmolsen commented Dec 9, 2015

ctrl+shift+0 on demo.patternlab.io works for me on Safari/Mac and Chrome/Mac. Haven't had any issues. Double-check focus. So try making the iframe a little smaller, click in the grey and try the key combo. Then click inside the iframe and try the key combo. Might help you track down the issue.

@bmuenzenmeyer
Copy link
Member Author

Interesting, but still the same on my end.

I am certain focus is in the right place, as ctrl+shift+1 works no sweat, but ctrl+shift+0 does nothing. I'll do some more digging. I will try on some other Windows machines when I get a chance too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants