Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading instructions (1.X to 2.X) in wiki is missing some information #405

Closed
josketres opened this issue Jul 27, 2016 · 5 comments
Closed

Comments

@josketres
Copy link

Please add the following to the upgrading instructions in the wiki page in the section Upgrading from Pattern Lab 1.X to 2.X:

  • in the file 00-meta/_00-head.mustache replace {% pattern-lab-head %} with {{{ patternLabHead }}}
  • in the file 00-meta/_01-foot.mustache replace {% pattern-lab-foot %} with {{{ patternLabFoot }}}

It took me almost 1 hour reading the source-code to find out that this change was needed for the upgrade.

@bmuenzenmeyer bmuenzenmeyer modified the milestone: 2.4.0 Jul 29, 2016
@bradfrost
Copy link
Member

bradfrost commented Aug 1, 2016

@josketres Thanks very much for this info! I've updated the docs to include these changes for both PHP and Node. @bmuenzenmeyer, feel free to adjust milestone accordingly or whatever you need to do.

@josketres
Copy link
Author

Cool!
Are you also planning to add this info to the wiki (https://github.com/pattern-lab/patternlab-node/wiki/Upgrading)?
This is the documentation that I used for upgrading!

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Aug 1, 2016

I intend to update this too - since it contains additional information not present on the io site and people may find their way to it like you did.

@josketres
Copy link
Author

👍

@bmuenzenmeyer
Copy link
Member

I've updated the wiki to cover this, in addition to removing some confusing code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants