-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster pattern preprocessing #604
Comments
Anything we do needs to incorporate all of the async work @geoffp is doing. I suggest we merge |
unassigning myself - i only like to assign issues to things i plan to work on imminently |
Curious if https://github.com/pattern-lab/patternlab-node/releases/tag/v2.9.0 handled the majority of concerns. this issue is a bit to vague right now, but is good in an aspirational sense. for clarity's sake, i am removing from the 3.0 milestone |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I am using Pattern Lab Node
v4.7.2
onLinux
, with Nodev4.7.0
, using theGrunt
Edition.In Spirit of #316
Currently the
processPatternsIterative
andprocessPatternsRecursive
methods inpatternlab.js
take a long time (in terms of magnitudes 10 seconds), especially for large pattern trees with lots of data.We should therefor collect ideas how to improve this step.
Map
for this. This potentially prevents falling back to the file system every time a pattern is looked up.The text was updated successfully, but these errors were encountered: