Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster pattern preprocessing #604

Closed
tburny opened this issue Jan 30, 2017 · 5 comments
Closed

Faster pattern preprocessing #604

tburny opened this issue Jan 30, 2017 · 5 comments
Assignees

Comments

@tburny
Copy link

tburny commented Jan 30, 2017

I am using Pattern Lab Node v4.7.2 on Linux, with Node v4.7.0, using the Grunt Edition.
In Spirit of #316

Currently the processPatternsIterative and processPatternsRecursive methods in patternlab.js take a long time (in terms of magnitudes 10 seconds), especially for large pattern trees with lots of data.

We should therefor collect ideas how to improve this step.

  • Extend incremental builds to skip processing unchanged patterns?
  • Cache pattern lookups and use ES6 Map for this. This potentially prevents falling back to the file system every time a pattern is looked up.
  • your suggestion here
@bmuenzenmeyer
Copy link
Member

Anything we do needs to incorporate all of the async work @geoffp is doing. I suggest we merge dev into his branches asap. This will be a priority of mine. I know there are some PRs out there to this effect.

@geoffp
Copy link
Contributor

geoffp commented Jan 31, 2017

@bmuenzenmeyer, @tburny, see #562 (comment)

@bmuenzenmeyer
Copy link
Member

unassigning myself - i only like to assign issues to things i plan to work on imminently

@bmuenzenmeyer bmuenzenmeyer removed their assignment Apr 10, 2017
@bmuenzenmeyer
Copy link
Member

Curious if https://github.com/pattern-lab/patternlab-node/releases/tag/v2.9.0 handled the majority of concerns. this issue is a bit to vague right now, but is good in an aspirational sense.

for clarity's sake, i am removing from the 3.0 milestone

@bmuenzenmeyer bmuenzenmeyer removed this from the 3.0.0 milestone Apr 10, 2017
@stale
Copy link

stale bot commented Oct 2, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the needs response label Oct 2, 2017
@stale stale bot closed this as completed Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants