Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] add passive scroll event listeners on tabs #2600

Open
zeroedin opened this issue Oct 5, 2023 · 0 comments
Open

[feat] add passive scroll event listeners on tabs #2600

zeroedin opened this issue Oct 5, 2023 · 0 comments
Assignees
@zeroedin
Labels
feature New feature or request good 1st issue Good for newcomers to the project; requires at least an introductory knowledge of the language red hack day Good issue for Red Hack Day
Milestone
PatternFly Elemen...

Comments

@zeroedin
Copy link
Collaborator

zeroedin commented Oct 5, 2023

Small performance improvement for tabs/overflow controller

Touch and wheel event listeners are useful for tracking user interactions and creating custom scrolling experiences, but they can also delay page scrolling. Currently, browsers can't know if an event listener will prevent scrolling, so they always wait for the listener to finish executing before scrolling the page. Passive event listeners solve this problem by letting you indicate that an event listener will never prevent scrolling.

https://developer.chrome.com/en/docs/lighthouse/best-practices/uses-passive-event-listeners/
@zeroedin zeroedin added the feature New feature or request label Oct 5, 2023
@zeroedin zeroedin added this to the PatternFly Elements 2.x milestone Oct 5, 2023
@zeroedin zeroedin self-assigned this Oct 5, 2023
@bennypowers bennypowers moved this to In Progress 🟢 in Red Hat Design System Oct 18, 2023
@bennypowers bennypowers added the good 1st issue Good for newcomers to the project; requires at least an introductory knowledge of the language label Jun 10, 2024
@markcaron markcaron added the red hack day Good issue for Red Hack Day label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroedin zeroedin

Labels
feature New feature or request good 1st issue Good for newcomers to the project; requires at least an introductory knowledge of the language red hack day Good issue for Red Hack Day
Projects
None yet
Milestone
PatternFly Elements 5
Development

No branches or pull requests
3 participants
@zeroedin @bennypowers @markcaron