Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<pfe-autocomplete> cursor becomes lost under clear button with long queries #2887

Open
bexter89 opened this issue Dec 13, 2024 · 3 comments
Open
Assignees
Labels
bug priority: low Severity level: 3

Comments

@bexter89
Copy link

Description of the issue

the CP-Search-Autocomplete uses version 1.12.3 under the hood.

The "Search the Customer Portal" search box on the https://access.redhat.com/ is unusable with long queries.

See: https://issues.redhat.com/browse/CPCORE-11969

Steps to reproduce

  1. Go to access.redhat.com
  2. Click on the search input in the hero and type a very long string
  3. Once the cursor goes under the X button on the right, you can't see what you're typing or editing anymore.

Expected behavior

as a user I expect for he cursor to remain visible as the string gets longer

Image

@bexter89 bexter89 added bug priority: low Severity level: 3 labels Dec 13, 2024
@bennypowers
Copy link
Member

We don't have any changes to the 1.x series planned. That being said, <pf-select variant="typeahead"> is available in version 4.0.0 of this library. Would you be interested in working with us to integrate that element into your application?

@markcaron
Copy link
Contributor

@bennypowers would it be possible to add the typeahead variant to a new <pf-input>? I feel like the old <pfe-autocomplete> is more like a text input than select.

@markcaron
Copy link
Contributor

Discussed in office hours this morning. This seems to be a good candidate for RHX Elements, since this pattern doesn't exist (AFAIK) in PatternFly and we don't have any official RHDS designs for this yet. The quickest route would be through RHX as—potentially—a combination of elements:

  • <rhx-datalist>
  • <rhx-combobox>
  • <rhx-textinput>

Up for debate. Might need some discovery on what composable bits make up a search autocomplete.

However, once @zeroedin's PR for <rhx-grid> is merged we can begin adding other RHX Elements.

CC: @bexter89 @diwanshi @ArathyKumar

@ArathyKumar ArathyKumar self-assigned this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug priority: low Severity level: 3
Projects
None yet
Development

No branches or pull requests

4 participants