Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Dark and light mode are not saved when refreshing the browser #4365

Closed
dlabaj opened this issue Oct 31, 2024 · 0 comments · Fixed by #4389 · May be fixed by #4367
Closed

Bug - Dark and light mode are not saved when refreshing the browser #4365

dlabaj opened this issue Oct 31, 2024 · 0 comments · Fixed by #4389 · May be fixed by #4367
Assignees
@dlabaj
Labels
PF Team PF6
Milestone
2024.Q4

Comments

@dlabaj
Copy link
Contributor

dlabaj commented Oct 31, 2024

Describe the problem
When using the website it was noticed that if you refresh the page or navigate away from the page the users current choice is not save in the browser. This information should persist upon page refresh or when navigating back to the site.

Expected behavior
Selected theme persists for the user within their browser.
@dlabaj dlabaj added the PF6 label Oct 31, 2024
@dlabaj dlabaj added this to the 2024.Q4 milestone Oct 31, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Oct 31, 2024
@dlabaj dlabaj self-assigned this Oct 31, 2024
@dlabaj dlabaj mentioned this issue Oct 31, 2024
Open
@kmcfaul kmcfaul moved this from Needs triage to Not started in PatternFly Issues Nov 4, 2024
@kmcfaul kmcfaul moved this from Not started to PR Review in PatternFly Issues Nov 4, 2024
@kmcfaul kmcfaul linked a pull request Nov 6, 2024 that will close this issue
fix: Adds ability to persist theming to local storage. #4367
Open
jonkoops added a commit to jonkoops/patternfly-org that referenced this issue Nov 21, 2024
@jonkoops
fix: improve handling of dark mode preferences
5e6a088 
Closes patternfly#4365

Signed-off-by: Jon Koops <jonkoops@gmail.com>
@jonkoops jonkoops mentioned this issue Nov 21, 2024
Merged
jonkoops added a commit to jonkoops/patternfly-org that referenced this issue Nov 21, 2024
@jonkoops
fix: improve handling of dark mode preferences
b252f95 
Closes patternfly#4365

Signed-off-by: Jon Koops <jonkoops@gmail.com>
jonkoops added a commit to jonkoops/patternfly-org that referenced this issue Nov 22, 2024
@jonkoops
fix: improve handling of dark mode preferences
b6ea0d4 
Closes patternfly#4365

Signed-off-by: Jon Koops <jonkoops@gmail.com>
@dlabaj dlabaj closed this as completed in 1580900 Nov 22, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlabaj dlabaj

Labels
PF Team PF6
Projects
PatternFly Issues
Status: Done
PatternFly Extensions
Status: No status
Milestone
2024.Q4
1 participant
@dlabaj