Skip to content

fix(NotificationBadge): add Button.variant to allowed NotificationBadgeVariants #3242

fix(NotificationBadge): add Button.variant to allowed NotificationBadgeVariants

fix(NotificationBadge): add Button.variant to allowed NotificationBadgeVariants #3242

Triggered via pull request October 15, 2025 20:46
Status Failure
Total duration 1m 38s
Artifacts

main.yml

on: pull_request
Build demo app
0s
Build demo app
Unit tests
Unit tests
Matrix: Integration tests
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 10 warnings
Build
Process completed with exit code 2.
Build: packages/react-core/src/components/NotificationBadge/NotificationBadge.tsx#L83
Type '"link" | "warning" | "read" | "primary" | "secondary" | "tertiary" | "danger" | "plain" | "control" | "stateful" | "unread" | "attention" | NotificationBadgeVariant' is not assignable to type '"read" | "unread" | "attention"'.
Lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L144
React Hook useEffect has a missing dependency: 'dateParse'. Either include it or remove the dependency array. If 'dateParse' changes too often, find the parent component that defines it and wrap that definition in useCallback
Lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L133
React Hook useMemo has a missing dependency: 'placeholder.length'. Either include it or remove the dependency array
Lint: packages/react-core/src/components/Card/examples/CardWithModifiers.tsx#L18
Mutating a value returned from 'useState()', which should not be mutated. Use the setter function to update instead
Lint: packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx#L191
React Hook useEffect has a missing dependency: 'shouldFocus'. Either include it or remove the dependency array
Lint: packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx#L184
React Hook useEffect has a missing dependency: 'focusedDate'. Either include it or remove the dependency array
Lint: packages/react-core/src/components/BackToTop/BackToTop.tsx#L36
The 'toggleVisible' function makes the dependencies of useEffect Hook (at line 74) change on every render. Move it inside the useEffect callback. Alternatively, wrap the definition of 'toggleVisible' in its own useCallback() Hook
Lint: packages/react-core/src/components/Alert/AlertGroup.tsx#L70
React Hook useEffect has a missing dependency: 'getTargetElement'. Either include it or remove the dependency array
Lint: packages/react-core/src/components/Alert/Alert.tsx#L167
React Hook useEffect has missing dependencies: 'hasAnimations', 'offstageRight', and 'updateTransitionEnd'. Either include them or remove the dependency array
Lint: packages/react-charts/src/victory/components/ChartTooltip/examples/ChartTooltipLegend.tsx#L14
Hooks must be called at the top level in the body of a function component or custom hook, and may not be called within function expressions. See the Rules of Hooks (https://react.dev/warnings/invalid-hook-call-warning)
Lint: packages/react-charts/src/victory/components/ChartLegend/examples/ChartLegendTooltips.tsx#L20
Hooks must be called at the top level in the body of a function component or custom hook, and may not be called within function expressions. See the Rules of Hooks (https://react.dev/warnings/invalid-hook-call-warning)