Skip to content

Commit

Permalink
Rebase v6 (#9899)
Browse files Browse the repository at this point in the history
* fix(RTL): added right-to-left page demo (#9694)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.20
 - @patternfly/react-core@5.2.0-prerelease.20
 - @patternfly/react-docs@6.2.0-prerelease.20
 - demo-app-ts@5.1.1-prerelease.43
 - @patternfly/react-table@5.2.0-prerelease.20

* fix(Wizard): onStepChange - skip isDisabled & isHidden (#9748)

* fix(Text input): Added aria-expanded (#9705)

* fix(Text input): Added aria-expanded

* add interface

* updates from review

* fix(Notification Drawer): Added screen reader text for notification drawer item read state (#9569)

* fix(Notification Drawer): Added screen reader text for notification drawer item read state

* fix snapshot

* Update prop description

* add aria-live

* update snapshots

* feat(Wizard): ability to add props to WizardFooter buttons (#9709)

* feat: ability to add props to WizardFooter buttons

* fix(WizardFooter): null check

* fix(Wizard): simpler design of adding footer buttons props

* test(Wizard): can add props to footer buttons

* docs(WizardFooter): move comment so docs have correct description

* refactor(WizardFooter): move FooterButtonProps to types file

* chore(Divider): update tests to new standards (#9714)

* chore(Divider): update tests to new standards

* changes from PR review

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.21
 - @patternfly/react-core@5.2.0-prerelease.21
 - @patternfly/react-docs@6.2.0-prerelease.21
 - demo-app-ts@5.1.1-prerelease.44
 - @patternfly/react-table@5.2.0-prerelease.21

* fix(TreeView): define button type (#9770)

* bug(build): fixed built ESM files importing CJS files from react-styles (#9347)

* bug(build): fixed built ESM files importing CJS files from react-styles

* edited yarn.lock to invalidate deps cache in GH actions

* excluded file extensions from react-styles path transform in ESM build

* updated jest config to transform .mjs files

* updated pr action to invalidate deps cache if package files added/edited

* chore(deps): Add ts-node to support executing typescript files directly

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.22
 - @patternfly/react-core@5.2.0-prerelease.22
 - @patternfly/react-docs@6.2.0-prerelease.22
 - demo-app-ts@5.1.1-prerelease.45
 - @patternfly/react-table@5.2.0-prerelease.22
 - transformer-react-styles-esm-imports@1.0.1-prerelease.0

* chore(deps): update dependency @patternfly/patternfly to v5.2.0-prerelease.4 (#9780)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-charts@7.2.0-prerelease.6
 - @patternfly/react-code-editor@5.2.0-prerelease.23
 - @patternfly/react-core@5.2.0-prerelease.23
 - @patternfly/react-docs@6.2.0-prerelease.23
 - @patternfly/react-icons@5.2.0-prerelease.6
 - demo-app-ts@5.1.1-prerelease.46
 - @patternfly/react-styles@5.2.0-prerelease.4
 - @patternfly/react-table@5.2.0-prerelease.23
 - @patternfly/react-tokens@5.2.0-prerelease.5

* feat(Datalist): implement full page Basic demo to match HTML #9048 (#9087)

* feat(Datalist): implement full page Basic demo to match HTML #9048

* fix syntax error

* comments applied

* comments applied

* comments applied

* comments applied

* \xa0 comments applied

* move key per review comments

* address PR comments

* revert change to package.json

* Converted basic demo to TS

---------

Co-authored-by: nicolethoen <nthoen@redhat.com>
Co-authored-by: Eric Olkowski <thatblindgeye@gmail.com>

* fix(ClipboardCopy): kepp caret position (#9772)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.24
 - @patternfly/react-core@5.2.0-prerelease.24
 - @patternfly/react-docs@6.2.0-prerelease.24
 - demo-app-ts@5.1.1-prerelease.47
 - @patternfly/react-table@5.2.0-prerelease.24

* chore(deps): update devdependencies (#9757)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @patternfly/patternfly to v5.2.0-prerelease.5 (#9806)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update devdependencies (#9800)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-charts@7.2.0-prerelease.7
 - @patternfly/react-code-editor@5.2.0-prerelease.25
 - @patternfly/react-core@5.2.0-prerelease.25
 - @patternfly/react-docs@6.2.0-prerelease.25
 - @patternfly/react-icons@5.2.0-prerelease.7
 - demo-app-ts@5.1.1-prerelease.48
 - @patternfly/react-styles@5.2.0-prerelease.5
 - @patternfly/react-table@5.2.0-prerelease.25
 - @patternfly/react-tokens@5.2.0-prerelease.6

* fix(DatePicker): updated logic for parsing and focus management (#9794)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.26
 - @patternfly/react-core@5.2.0-prerelease.26
 - @patternfly/react-docs@6.2.0-prerelease.26
 - demo-app-ts@5.1.1-prerelease.49
 - @patternfly/react-table@5.2.0-prerelease.26

* chore(PrimaryDetail): convert demos to TS (#9787)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.27
 - @patternfly/react-core@5.2.0-prerelease.27
 - @patternfly/react-docs@6.2.0-prerelease.27
 - demo-app-ts@5.1.1-prerelease.50
 - @patternfly/react-table@5.2.0-prerelease.27

* chore(misc): clean up instances of Array.apply (#9798)

* clean up instances of Array.apply

* rename item to value

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.28
 - @patternfly/react-core@5.2.0-prerelease.28
 - @patternfly/react-docs@6.2.0-prerelease.28
 - @patternfly/react-integration@5.1.1-prerelease.15
 - demo-app-ts@5.1.1-prerelease.51
 - @patternfly/react-table@5.2.0-prerelease.28

* chore(eslint): Added React Testing Library linter plugin (#9805)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.29
 - @patternfly/react-core@5.2.0-prerelease.29
 - @patternfly/react-docs@6.2.0-prerelease.29
 - @patternfly/react-icons@5.2.0-prerelease.8
 - demo-app-ts@5.1.1-prerelease.52
 - @patternfly/react-table@5.2.0-prerelease.29

* chore(DataList): update tests (#9672)

* add spread prop test, update test

* chore(DataList): update tests

* fix merge error

* break out into separate files, pr feedback

* updates

* fix some example ids

* minor test updates

* revert action change

* bug(ClipboardCopy): change children type to string (#9743)

* bug(ClipboardCopy): change children type to string

Signed-off-by: gitdallas <dallas.nicol@gmail.com>

* fix clipboardcopyexpanded to work with string children

Signed-off-by: gitdallas <dallas.nicol@gmail.com>

* refactor a bit

* fix bad rebase

---------

Signed-off-by: gitdallas <dallas.nicol@gmail.com>

* chore(deps): update devdependencies (#9817)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix Search Input - composable advanced search demo (#9484)

* Search Input - composable advanced search fix date

* remove isFill from datePicker

* docs(custom menu): add example with search input inline filtering (#9687)

* docs(custom menu): add example with search input inline filtering

* refactor(demo menu): rename to InlineSearchFilterMenuDemo

* chore(HelperText): update tests (#9761)

* chore(HelperText): update tests

* break out helpertextitem tests, update tests

* updates

* fix lint

* fix(Chip): update tooltip vis when chip updates (#9819)

* fix(Chip): enable tooltip when chip updates

* fix casting

* chore(DescriptionList): update tests (#9753)

* chore(DescriptionList): update tests

* break out tests, pr feedback

* updates

* add autofit width mod test

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.30
 - @patternfly/react-core@5.2.0-prerelease.30
 - @patternfly/react-docs@6.2.0-prerelease.30
 - demo-app-ts@5.1.1-prerelease.53
 - @patternfly/react-table@5.2.0-prerelease.30

* chore(TreeView): updated tests (#9773)

* chore(TreeView): updated tests

* Added tests for TreeViewListItem

* Added tests for TreeViewRoot and TreeView

* Updated snapshots and queries

* chore(Table) convert demos to ts (#9621)

* chore(table) convert to TS

chore(DashboardWrapper) convert to TS

chore(Table) convert demos to TS

delete superfluous dashboard components

declare as ts files

remove duplicate ids

fix import errors, WIP build errors

sync toolbar demo with main

* update import paths

* fix more import paths

* try import from dist/esm

* fix build

* convert remaining table demos to ts, WIP draggable logic

* revert col management with draggable to previous dnd implementation

* align file names with demo names, cleanup types, fix TS errors in demo files

* update fileNames in table.md

* PR feedback from Eric

* fix category dropdown

* fix demos, remove table actions that do not support main purpose of column management demos

* add fix for a11y tests as suggested by Eric

* update toolbar snap

* add param type to labelText

---------

Co-authored-by: Jenny <32821331+jenny-s51@users.noreply.github.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.31
 - @patternfly/react-core@5.2.0-prerelease.31
 - @patternfly/react-docs@6.2.0-prerelease.31
 - demo-app-ts@5.1.1-prerelease.54
 - @patternfly/react-table@5.2.0-prerelease.31

* chore(deps): update devdependencies (#9829)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* docs(select): Adds documentation to React examples. (#9536)

* fix conflicts

* docs(select): Adds documentation for React examples.

* Adds content to new select React examples.

* Updates typeahead with create example.

* Clarify mult typeahead with create content.

* Finalizing wording.

* Updates content from review.

---------

Co-authored-by: nicolethoen <nthoen@redhat.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.32
 - @patternfly/react-core@5.2.0-prerelease.32
 - @patternfly/react-docs@6.2.0-prerelease.32
 - demo-app-ts@5.1.1-prerelease.55
 - @patternfly/react-table@5.2.0-prerelease.32

* chore(deps): update devdependencies (#9833)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update devdependencies (#9837)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix link to patternfly community contributors document (#9840)

* chore(deps): update devdependencies (#9846)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(Table): make tooltip prop consistent (#9803)

* fix(Table): make tooltip prop consistent

* make tooltip ReactNode and add tooltipProps to Th

* add prop to useEffect

* fix logic for keyboard focus

* fix useeffect

* chore(DataList): convert data list react demo to TS (#9818)

* convert data list react demo to TS

* update function component name to match file

* fix(AlertGroupDemo): crashed when adding default alerts (#9826)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.33
 - @patternfly/react-core@5.2.0-prerelease.33
 - @patternfly/react-docs@6.2.0-prerelease.33
 - demo-app-ts@5.1.1-prerelease.56
 - @patternfly/react-table@5.2.0-prerelease.33

* chore(deps): update dependency @types/jest to v29.5.11 (#9854)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update Popover returnFocusOnDeactivate prop (#9865)

Closes #9863

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.34
 - @patternfly/react-core@5.2.0-prerelease.34
 - @patternfly/react-docs@6.2.0-prerelease.34
 - demo-app-ts@5.1.1-prerelease.57
 - @patternfly/react-table@5.2.0-prerelease.34

* chore(deps): update dependency @patternfly/patternfly to v5.2.0-prerelease.7 (#9867)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-charts@7.2.0-prerelease.8
 - @patternfly/react-code-editor@5.2.0-prerelease.35
 - @patternfly/react-core@5.2.0-prerelease.35
 - @patternfly/react-docs@6.2.0-prerelease.35
 - @patternfly/react-icons@5.2.0-prerelease.9
 - demo-app-ts@5.1.1-prerelease.58
 - @patternfly/react-styles@5.2.0-prerelease.6
 - @patternfly/react-table@5.2.0-prerelease.35
 - @patternfly/react-tokens@5.2.0-prerelease.7

* chore(deps): update devdependencies (#9873)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(MenuItem): Add download to MenuItem (#9892)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.36
 - @patternfly/react-core@5.2.0-prerelease.36
 - @patternfly/react-docs@6.2.0-prerelease.36
 - @patternfly/react-integration@5.1.1-prerelease.16
 - demo-app-ts@5.1.1-prerelease.59
 - @patternfly/react-table@5.2.0-prerelease.36

---------

Signed-off-by: gitdallas <dallas.nicol@gmail.com>
Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
Co-authored-by: patternfly-build <patternfly-build@redhat.com>
Co-authored-by: Jeff Puzzo <96431149+jpuzz0@users.noreply.github.com>
Co-authored-by: adamviktora <84135613+adamviktora@users.noreply.github.com>
Co-authored-by: Mark Franceschelli <39063664+mfrances17@users.noreply.github.com>
Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>
Co-authored-by: Austin Sullivan <ausulliv@redhat.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Kells512 <72694484+Kells512@users.noreply.github.com>
Co-authored-by: nicolethoen <nthoen@redhat.com>
Co-authored-by: Eric Olkowski <thatblindgeye@gmail.com>
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
Co-authored-by: Jenny <32821331+jenny-s51@users.noreply.github.com>
Co-authored-by: Dallas <dallas.nicol@gmail.com>
Co-authored-by: Maria <mariaaga@redhat.com>
Co-authored-by: Dominik Petřík <77832970+Dominik-Petrik@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Yurith Rubio <78481690+yurith-rubio@users.noreply.github.com>
Co-authored-by: Joachim Schuler <jdh.schuler@gmail.com>
Co-authored-by: Robb Hamilton <rhamilto@redhat.com>
  • Loading branch information
1 parent 0213323 commit 007dc2c
Show file tree
Hide file tree
Showing 29 changed files with 1,135 additions and 529 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ If you want to start with your existing project, skip to [Install and configure
Once the library is installed, use the specific setup instructions for that library to access the components it contains. These can be found in the readme for each [library](#patternfly-react-packages).

### Contribution guidelines
All React contributors must first be [PatternFly community contributors](https://www.patternfly.org/contribute/about). If you're already a PatternFly community contributor, check out the [React contribution guidelines](https://github.com/patternfly/patternfly-react/tree/main/CONTRIBUTING.md) to make React contributions.
All React contributors must first be [PatternFly community contributors](https://www.patternfly.org/get-started/contribute/contributing-to-patternfly). If you're already a PatternFly community contributor, check out the [React contribution guidelines](https://github.com/patternfly/patternfly-react/tree/main/CONTRIBUTING.md) to make React contributions.


### License
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^13.4.0",
"@testing-library/user-event": "14.5.1",
"@types/jest": "29.5.8",
"@types/jest": "29.5.11",
"@types/react": "^18",
"@types/react-dom": "^18",
"@typescript-eslint/eslint-plugin": "^5.59.2",
Expand Down
12 changes: 12 additions & 0 deletions packages/react-charts/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,18 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline

**Note:** Version bump only for package @patternfly/react-charts

# 7.2.0-prerelease.8 (2023-12-11)

**Note:** Version bump only for package @patternfly/react-charts

# 7.2.0-prerelease.7 (2023-11-10)

**Note:** Version bump only for package @patternfly/react-charts

# 7.2.0-prerelease.6 (2023-11-03)

**Note:** Version bump only for package @patternfly/react-charts

# 7.2.0-prerelease.5 (2023-10-26)

**Note:** Version bump only for package @patternfly/react-charts
Expand Down
68 changes: 68 additions & 0 deletions packages/react-code-editor/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,74 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.36](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.35...@patternfly/react-code-editor@5.2.0-prerelease.36) (2023-12-14)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.35](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.34...@patternfly/react-code-editor@5.2.0-prerelease.35) (2023-12-11)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.34](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.33...@patternfly/react-code-editor@5.2.0-prerelease.34) (2023-12-07)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.33](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.32...@patternfly/react-code-editor@5.2.0-prerelease.33) (2023-12-06)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.32](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.31...@patternfly/react-code-editor@5.2.0-prerelease.32) (2023-11-21)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.31](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.30...@patternfly/react-code-editor@5.2.0-prerelease.31) (2023-11-17)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.30](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.29...@patternfly/react-code-editor@5.2.0-prerelease.30) (2023-11-16)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.29](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.28...@patternfly/react-code-editor@5.2.0-prerelease.29) (2023-11-14)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.28](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.27...@patternfly/react-code-editor@5.2.0-prerelease.28) (2023-11-14)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.27](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.26...@patternfly/react-code-editor@5.2.0-prerelease.27) (2023-11-14)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.26](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.25...@patternfly/react-code-editor@5.2.0-prerelease.26) (2023-11-13)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.25](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.24...@patternfly/react-code-editor@5.2.0-prerelease.25) (2023-11-10)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.24](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.23...@patternfly/react-code-editor@5.2.0-prerelease.24) (2023-11-03)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.23](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.22...@patternfly/react-code-editor@5.2.0-prerelease.23) (2023-11-03)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.22](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.21...@patternfly/react-code-editor@5.2.0-prerelease.22) (2023-11-02)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.21](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.20...@patternfly/react-code-editor@5.2.0-prerelease.21) (2023-11-02)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.20](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.19...@patternfly/react-code-editor@5.2.0-prerelease.20) (2023-11-02)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.19](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.18...@patternfly/react-code-editor@5.2.0-prerelease.19) (2023-10-30)

**Note:** Version bump only for package @patternfly/react-code-editor
Expand Down
94 changes: 94 additions & 0 deletions packages/react-core/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,100 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline

- **RTL:** added right-to-left page demo ([#9694](https://github.com/patternfly/patternfly-react/issues/9694)) ([d7308ae](https://github.com/patternfly/patternfly-react/commit/d7308aebec1e3ff22df548b5613f058c9ba35262))

# [5.2.0-prerelease.36](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.35...@patternfly/react-core@5.2.0-prerelease.36) (2023-12-14)

### Bug Fixes

- **MenuItem:** Add download to MenuItem ([#9892](https://github.com/patternfly/patternfly-react/issues/9892)) ([2afb5fd](https://github.com/patternfly/patternfly-react/commit/2afb5fdeb8ade43aee6dadaccf9067a0939212c7))

# [5.2.0-prerelease.35](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.34...@patternfly/react-core@5.2.0-prerelease.35) (2023-12-11)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.34](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.33...@patternfly/react-core@5.2.0-prerelease.34) (2023-12-07)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.33](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.32...@patternfly/react-core@5.2.0-prerelease.33) (2023-12-06)

### Bug Fixes

- **AlertGroupDemo:** crashed when adding default alerts ([#9826](https://github.com/patternfly/patternfly-react/issues/9826)) ([9244cf0](https://github.com/patternfly/patternfly-react/commit/9244cf07bd599f295d623a6e37e8d15b3c7c3d40))

# [5.2.0-prerelease.32](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.31...@patternfly/react-core@5.2.0-prerelease.32) (2023-11-21)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.31](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.30...@patternfly/react-core@5.2.0-prerelease.31) (2023-11-17)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.30](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.29...@patternfly/react-core@5.2.0-prerelease.30) (2023-11-16)

### Bug Fixes

- **Chip:** update tooltip vis when chip updates ([#9819](https://github.com/patternfly/patternfly-react/issues/9819)) ([18c140a](https://github.com/patternfly/patternfly-react/commit/18c140a2adcc1833e4b095755aa7495d1d88a177))

# [5.2.0-prerelease.29](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.28...@patternfly/react-core@5.2.0-prerelease.29) (2023-11-14)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.28](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.27...@patternfly/react-core@5.2.0-prerelease.28) (2023-11-14)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.27](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.26...@patternfly/react-core@5.2.0-prerelease.27) (2023-11-14)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.26](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.25...@patternfly/react-core@5.2.0-prerelease.26) (2023-11-13)

### Bug Fixes

- **DatePicker:** updated logic for parsing and focus management ([#9794](https://github.com/patternfly/patternfly-react/issues/9794)) ([a12cf31](https://github.com/patternfly/patternfly-react/commit/a12cf313f0924a61a8cf20ee78b4b27290b9c05f))

# [5.2.0-prerelease.25](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.24...@patternfly/react-core@5.2.0-prerelease.25) (2023-11-10)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.24](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.23...@patternfly/react-core@5.2.0-prerelease.24) (2023-11-03)

### Bug Fixes

- **ClipboardCopy:** kepp caret position ([#9772](https://github.com/patternfly/patternfly-react/issues/9772)) ([981361e](https://github.com/patternfly/patternfly-react/commit/981361e0de354bbe06c4a799b6e7c92228dab51f))

### Features

- **Datalist:** implement full page Basic demo to match HTML [#9048](https://github.com/patternfly/patternfly-react/issues/9048) ([#9087](https://github.com/patternfly/patternfly-react/issues/9087)) ([ab18059](https://github.com/patternfly/patternfly-react/commit/ab1805993ed5e2b5ed3d2f1be4131e035152b468))

# [5.2.0-prerelease.23](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.22...@patternfly/react-core@5.2.0-prerelease.23) (2023-11-03)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.22](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.21...@patternfly/react-core@5.2.0-prerelease.22) (2023-11-02)

### Bug Fixes

- **TreeView:** define button type ([#9770](https://github.com/patternfly/patternfly-react/issues/9770)) ([a772c6d](https://github.com/patternfly/patternfly-react/commit/a772c6d67bfa4154979ee14a34ec954406503109))

# [5.2.0-prerelease.21](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.20...@patternfly/react-core@5.2.0-prerelease.21) (2023-11-02)

### Bug Fixes

- **Notification Drawer:** Added screen reader text for notification drawer item read state ([#9569](https://github.com/patternfly/patternfly-react/issues/9569)) ([bc19f91](https://github.com/patternfly/patternfly-react/commit/bc19f9148e872fb62d8cd2bf644a771d9c5650d7))
- **Text input:** Added aria-expanded ([#9705](https://github.com/patternfly/patternfly-react/issues/9705)) ([7f6a62c](https://github.com/patternfly/patternfly-react/commit/7f6a62c1a3f860a8759c63cde17da6b763dd7b48))
- **Wizard:** onStepChange - skip isDisabled & isHidden ([#9748](https://github.com/patternfly/patternfly-react/issues/9748)) ([4d4d623](https://github.com/patternfly/patternfly-react/commit/4d4d623d294bbc7821c6dc9156980f2b8c609c96))

### Features

- **Wizard:** ability to add props to WizardFooter buttons ([#9709](https://github.com/patternfly/patternfly-react/issues/9709)) ([9f21cee](https://github.com/patternfly/patternfly-react/commit/9f21cee5438c8ec4d0e2c5c938f9fffda013757b))

# [5.2.0-prerelease.20](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.19...@patternfly/react-core@5.2.0-prerelease.20) (2023-11-02)

### Bug Fixes

- **RTL:** added right-to-left page demo ([#9694](https://github.com/patternfly/patternfly-react/issues/9694)) ([d7308ae](https://github.com/patternfly/patternfly-react/commit/d7308aebec1e3ff22df548b5613f058c9ba35262))

# [5.2.0-prerelease.19](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.18...@patternfly/react-core@5.2.0-prerelease.19) (2023-10-30)

**Note:** Version bump only for package @patternfly/react-core
Expand Down
6 changes: 5 additions & 1 deletion packages/react-core/src/components/Menu/MenuItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ export interface MenuItemProps extends Omit<React.HTMLProps<HTMLLIElement>, 'onC
target?: string;
/** Navigation link relationship. Only set when the to property is present. */
rel?: string;
/** Navigation link download. Only set when the to property is present. */
download?: string;
/** Flag indicating the item has a checkbox */
hasCheckbox?: boolean;
/** Flag indicating whether the item is active */
Expand Down Expand Up @@ -119,6 +121,7 @@ const MenuItemBase: React.FunctionComponent<MenuItemProps> = ({
tooltipProps,
rel,
target,
download,
...props
}: MenuItemProps) => {
const {
Expand Down Expand Up @@ -271,7 +274,8 @@ const MenuItemBase: React.FunctionComponent<MenuItemProps> = ({
// prevent invalid 'disabled' attribute on <a> tags
disabled: null,
target: isExternalLink ? '_blank' : target,
rel
rel,
download
};
} else if (Component === 'button') {
additionalProps = {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Popover/Popover.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ export const Popover: React.FunctionComponent<PopoverProps> = ({
ref={popoverRef}
active={focusTrapActive}
focusTrapOptions={{
returnFocusOnDeactivate: true,
returnFocusOnDeactivate: propWithFocusTrap !== false,
clickOutsideDeactivates: true,
// FocusTrap's initialFocus can accept false as a value to prevent initial focus.
// We want to prevent this in case false is ever passed in.
Expand Down
Loading

0 comments on commit 007dc2c

Please sign in to comment.