Address feedback about types

Author: mturley

packages/react-core/src/components/FileUpload/FileUpload.tsx

@@ -1,5 +1,5 @@
 import * as React from 'react';
-import Dropzone, { DropzoneProps } from 'react-dropzone';
+import Dropzone, { DropzoneProps, DropFileEventHandler } from 'react-dropzone';
 import { Omit } from '../../helpers';
 import { FileUploadField, FileUploadFieldProps } from './FileUploadField';
 import { readFile, fileReaderType } from '../../helpers/fileUtils';
@@ -75,22 +75,20 @@ export interface FileUploadProps
   dropzoneProps?: DropzoneProps;
 }
 
-// TODO handle an optional message for errors without using FieldGroup
-
 export const FileUpload: React.FunctionComponent<FileUploadProps> = ({
   id,
   type,
   value = type === fileReaderType.text || type === fileReaderType.dataURL ? '' : null,
   filename = '',
   children = null,
-  onChange = (): any => undefined,
-  onReadStarted = (): any => undefined,
-  onReadFinished = (): any => undefined,
-  onReadFailed = (): any => undefined,
+  onChange = () => {},
+  onReadStarted = () => {},
+  onReadFinished = () => {},
+  onReadFailed = () => {},
   dropzoneProps = {},
   ...props
 }: FileUploadProps) => {
-  const onDropAccepted = async (acceptedFiles: File[], event: React.DragEvent<HTMLElement>) => {
+  const onDropAccepted: DropFileEventHandler = async (acceptedFiles: File[], event: React.DragEvent<HTMLElement>) => {
     if (acceptedFiles.length > 0) {
       const fileHandle = acceptedFiles[0];
       if (type === fileReaderType.text || type === fileReaderType.dataURL) {
@@ -110,7 +108,7 @@ export const FileUpload: React.FunctionComponent<FileUploadProps> = ({
     dropzoneProps.onDropAccepted && dropzoneProps.onDropAccepted(acceptedFiles, event);
   };
 
-  const onDropRejected = (rejectedFiles: File[], event: React.DragEvent<HTMLElement>) => {
+  const onDropRejected: DropFileEventHandler = (rejectedFiles: File[], event: React.DragEvent<HTMLElement>) => {
     if (rejectedFiles.length > 0) {
       onChange('', rejectedFiles[0].name, event);
     }

packages/react-core/src/components/FileUpload/FileUploadField.tsx

@@ -78,17 +78,17 @@ export interface FileUploadFieldProps extends Omit<React.HTMLProps<HTMLDivElemen
   /** Flag to show if a file is being dragged over the field */
   isDragActive?: boolean;
   /** A reference object to attach to the FileUploadField container element. */
-  containerRef?: React.Ref<any>;
+  containerRef?: React.Ref<HTMLDivElement>;
 }
 
 export const FileUploadField: React.FunctionComponent<FileUploadFieldProps> = ({
   id,
   type,
   value = '',
   filename = '',
-  onChange = (): any => undefined,
-  onBrowseButtonClick = (): any => undefined,
-  onClearButtonClick = (): any => undefined,
+  onChange = () => {},
+  onBrowseButtonClick = () => {},
+  onClearButtonClick = () => {},
   className = '',
   isDisabled = false,
   isReadOnly = false,
@@ -104,7 +104,7 @@ export const FileUploadField: React.FunctionComponent<FileUploadFieldProps> = ({
   browseButtonText = 'Browse...',
   clearButtonText = 'Clear',
   isClearButtonDisabled = !filename && !value,
-  containerRef = null as React.Ref<any>,
+  containerRef = null as React.Ref<HTMLDivElement>,
   children = null,
   showPreview = false,
   ...props