Skip to content

Commit 087949d

Browse files
authored
feat(Popper): add passthrough for offset (#11994)
* feat(Popper): add passthrough for offset * update to use popper's offset interface
1 parent 2af86aa commit 087949d

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

packages/react-core/src/helpers/Popper/Popper.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { cloneElement, isValidElement, useCallback, useEffect, useMemo, useRef, useState } from 'react';
22
import * as ReactDOM from 'react-dom';
33
import { usePopper } from './thirdparty/react-popper/usePopper';
4+
import { Options as OffsetOptions } from './thirdparty/popper-core/modifiers/offset';
45
import { Placement, Modifier } from './thirdparty/popper-core';
56
import { clearTimeouts } from '../util';
67
import { css } from '@patternfly/react-styles';
@@ -107,6 +108,8 @@ export interface PopperProps {
107108
};
108109
/** Distance of the popper to the trigger */
109110
distance?: number;
111+
/** Override for the popper's offset */
112+
offset?: OffsetOptions['offset'];
110113
/** Callback function when mouse enters trigger */
111114
onMouseEnter?: (event?: MouseEvent) => void;
112115
/** Callback function when mouse leaves trigger */
@@ -190,6 +193,7 @@ export const Popper: React.FunctionComponent<PopperProps> = ({
190193
isVisible = true,
191194
positionModifiers,
192195
distance = 0,
196+
offset,
193197
onMouseEnter,
194198
onMouseLeave,
195199
onFocus,
@@ -420,7 +424,7 @@ export const Popper: React.FunctionComponent<PopperProps> = ({
420424
{
421425
name: 'offset',
422426
options: {
423-
offset: [0, distance]
427+
offset: offset || [0, distance]
424428
}
425429
},
426430
{

0 commit comments

Comments
 (0)