chore(react-core): remove exenv and lodash (#3882)

redallen · web-flow · commit 3bfcc002a7b7 · 2020-03-06T15:18:54.000-05:00
* chore(react-core): remove exenv and lodash

* remove accidental focus-trap change

* fix lint

* fix lint
diff --git a/packages/react-codemods/transforms/pf3-pf4.button.test.js b/packages/react-codemods/transforms/pf3-pf4.button.test.js
@@ -1,4 +1,3 @@
-import { EOL as SYSTEM_EOL } from 'os';
 import prettier from 'prettier';
 import { defineInlineTest } from 'jscodeshift/dist/testUtils';
 import transform from './pf3-pf4';
diff --git a/packages/react-codemods/transforms/pf3-pf4.js b/packages/react-codemods/transforms/pf3-pf4.js
@@ -1,4 +1,4 @@
-/* eslint-disable no-console */
+/* eslint-disable no-console,jsdoc/require-jsdoc */
 const colors = require('colors');
 const componentConfigs = require('../componentConfig');
 
diff --git a/packages/react-codemods/transforms/pf3-pf4.test.js b/packages/react-codemods/transforms/pf3-pf4.test.js
@@ -1,4 +1,3 @@
-import { EOL as SYSTEM_EOL } from 'os';
 import prettier from 'prettier';
 import { defineInlineTest, runInlineTest } from 'jscodeshift/dist/testUtils';
 import transform from './pf3-pf4';
diff --git a/packages/react-core/src/components/AboutModal/AboutModal.tsx b/packages/react-core/src/components/AboutModal/AboutModal.tsx
@@ -2,7 +2,7 @@ import * as React from 'react';
 import * as ReactDOM from 'react-dom';
 import { css } from '@patternfly/react-styles';
 import styles from '@patternfly/react-styles/css/components/Backdrop/backdrop';
-import { canUseDOM } from 'exenv';
+import { canUseDOM } from '../../helpers';
 import { KEY_CODES } from '../../helpers/constants';
 import { AboutModalContainer } from './AboutModalContainer';
 import { PickOptional } from '../../helpers/typeUtils';
diff --git a/packages/react-core/src/components/AlertGroup/AlertGroup.tsx b/packages/react-core/src/components/AlertGroup/AlertGroup.tsx
@@ -1,6 +1,6 @@
 import * as React from 'react';
 import * as ReactDOM from 'react-dom';
-import { canUseDOM } from 'exenv';
+import { canUseDOM } from '../../helpers';
 import { Omit } from '../../helpers/typeUtils';
 import { AlertGroupInline } from './AlertGroupInline';
 
diff --git a/packages/react-core/src/components/DataList/DataList.tsx b/packages/react-core/src/components/DataList/DataList.tsx
@@ -1,5 +1,4 @@
 import * as React from 'react';
-import { isUndefined } from 'lodash';
 
 import { css } from '@patternfly/react-styles';
 import styles from '@patternfly/react-styles/css/components/DataList/data-list';
@@ -38,7 +37,7 @@ export const DataList: React.FunctionComponent<DataListProps> = ({
   isCompact = false,
   ...props
 }: DataListProps) => {
-  const isSelectable = !isUndefined(onSelectDataListItem);
+  const isSelectable = onSelectDataListItem !== undefined;
 
   const updateSelectedDataListItem = (id: string) => {
     onSelectDataListItem(id);
diff --git a/packages/react-core/src/components/DataToolbar/DataToolbar.tsx b/packages/react-core/src/components/DataToolbar/DataToolbar.tsx
@@ -1,5 +1,4 @@
 import * as React from 'react';
-import { sum, values } from 'lodash';
 import styles from '@patternfly/react-styles/css/components/DataToolbar/data-toolbar';
 import { css } from '@patternfly/react-styles';
 import { DataToolbarContext } from './DataToolbarUtils';
@@ -91,7 +90,7 @@ export class DataToolbar extends React.Component<DataToolbarProps, DataToolbarSt
     }
   };
 
-  getNumberOfFilters = () => sum(values(this.state.filterInfo));
+  getNumberOfFilters = () => Object.values(this.state.filterInfo).reduce((acc, cur) => acc + cur, 0);
 
   render() {
     const {
diff --git a/packages/react-core/src/components/Modal/Modal.tsx b/packages/react-core/src/components/Modal/Modal.tsx
@@ -1,6 +1,6 @@
 import * as React from 'react';
 import * as ReactDOM from 'react-dom';
-import { canUseDOM } from 'exenv';
+import { canUseDOM } from '../../helpers';
 
 import { css } from '@patternfly/react-styles';
 import styles from '@patternfly/react-styles/css/components/Backdrop/backdrop';
diff --git a/packages/react-core/src/components/Tabs/Tab.tsx b/packages/react-core/src/components/Tabs/Tab.tsx
@@ -18,4 +18,4 @@ export interface TabProps extends Omit<React.HTMLProps<HTMLAnchorElement | HTMLB
   tabContentRef?: React.RefObject<any>;
 }
 
-export const Tab: React.FunctionComponent<TabProps> = ({ className = '' }: TabProps) => null;
+export const Tab: React.FunctionComponent<TabProps> = (_props: TabProps) => null;
diff --git a/packages/react-core/src/components/Wizard/Wizard.tsx b/packages/react-core/src/components/Wizard/Wizard.tsx
@@ -1,6 +1,6 @@
 import * as React from 'react';
 import * as ReactDOM from 'react-dom';
-import { canUseDOM } from 'exenv';
+import { canUseDOM } from '../../helpers';
 import { KEY_CODES } from '../../helpers/constants';
 import { css } from '@patternfly/react-styles';
 import styles from '@patternfly/react-styles/css/components/Wizard/wizard';
diff --git a/packages/react-core/src/components/withOuia/withOuia.tsx b/packages/react-core/src/components/withOuia/withOuia.tsx
@@ -1,6 +1,5 @@
 import * as React from 'react';
 import { isOUIAEnvironment, getUniqueId, generateOUIAId } from './ouia';
-import { Omit } from '../../helpers/typeUtils';
 
 export const OuiaContext = React.createContext<OuiaContextProps | null>(null);
 
diff --git a/packages/react-core/src/helpers/safeHTMLElement.js b/packages/react-core/src/helpers/safeHTMLElement.js
@@ -1,4 +1,4 @@
 // https://github.com/reactjs/react-modal/blob/master/src/helpers/safeHTMLElement.js
-import { canUseDOM } from 'exenv';
+import { canUseDOM } from './util';
 
 export default canUseDOM ? window.HTMLElement : {};
diff --git a/packages/react-core/src/helpers/util.ts b/packages/react-core/src/helpers/util.ts
@@ -247,3 +247,5 @@ export const formatBreakpointMods = (
       `${acc}${acc && ' '}${getModifier(styles, `${curr.modifier}${curr.breakpoint ? `-on-${curr.breakpoint}` : ''}`)}`,
     ''
   );
+
+export const canUseDOM = !!(typeof window !== 'undefined' && window.document && window.document.createElement);
diff --git a/packages/react-icons/src/createIcon.js b/packages/react-icons/src/createIcon.js
@@ -19,6 +19,7 @@ const createIcon = iconDefinition => {
     id = `icon-title-${currentId++}`;
 
     render() {
+      // eslint-disable-next-line @typescript-eslint/no-unused-vars
       const { size, color, title, noStyle, noVerticalAlign, ...props } = this.props;
 
       const hasTitle = Boolean(title);

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-import { EOL as SYSTEM_EOL } from 'os';`
`2`	`1`	`import prettier from 'prettier';`
`3`	`2`	`import { defineInlineTest } from 'jscodeshift/dist/testUtils';`
`4`	`3`	`import transform from './pf3-pf4';`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/* eslint-disable no-console */`
	`1`	`+/* eslint-disable no-console,jsdoc/require-jsdoc */`
`2`	`2`	`const colors = require('colors');`
`3`	`3`	`const componentConfigs = require('../componentConfig');`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -18,4 +18,4 @@ export interface TabProps extends Omit<React.HTMLProps<HTMLAnchorElement \| HTMLB`
`18`	`18`	`tabContentRef?: React.RefObject<any>;`
`19`	`19`	`}`
`20`	`20`
`21`		`-export const Tab: React.FunctionComponent<TabProps> = ({ className = '' }: TabProps) => null;`
	`21`	`+export const Tab: React.FunctionComponent<TabProps> = (_props: TabProps) => null;`