Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated dependencies #11491

Open
8 of 20 tasks
thatblindgeye opened this issue Jan 29, 2025 · 5 comments
Open
8 of 20 tasks

Update outdated dependencies #11491

thatblindgeye opened this issue Jan 29, 2025 · 5 comments
Labels

Comments

@thatblindgeye
Copy link
Contributor

thatblindgeye commented Jan 29, 2025

Replacement for #9127 (comment), the following are deps that need major bumps only; renovate will handle any minor bumps.

Note that react-router will be handled by #11172, and the React upgrades will be handled by #11371 (none of these deps are listed above)

@Mash707
Copy link
Contributor

Mash707 commented Feb 27, 2025

Hi @thatblindgeye I would like to work on this. I haven't worked much with upgrading dependencies in a large project.
I looked up previous PRs which involved updating dependecies. From what I understand is that we require to updates the versions in yarn.lock and package.json. Could you provide more information regarding this if possible?
Also Do I need to create separate PR for each dependency upgrade?
Thank You.

@thatblindgeye
Copy link
Contributor Author

@Mash707 Mainly updating versions in the package.json and building locally (this should update the yarn.lock automatically). Outside of that it could require resolving any errors that occur from upgrading -- though depending on the errors that may mean we have to wait until our next breaking change release to upgrade.

A separate PR would be good just in case there are issues that need to be resolved -- again depending on that it can be easier to review more PRs that are smaller in size than a huge single PR. That said grouping similar deps together would be fine, i.e. a single PR for both the dnd-kit upgrades needed.

That said if it feels overwhelming at all and you'd like to work on other issues in our react repo (outside the a11y ones you've picked up, which awesome job for taking those on) we can try to find some issues that might be a good fit (some of our issues might be goof first issues, we just haven't applied the label to them).

@Mash707
Copy link
Contributor

Mash707 commented Feb 28, 2025

@Mash707 Mainly updating versions in the package.json and building locally (this should update the yarn.lock automatically). Outside of that it could require resolving any errors that occur from upgrading -- though depending on the errors that may mean we have to wait until our next breaking change release to upgrade.

I'll try updating some packages and see how things go.

That said if it feels overwhelming at all and you'd like to work on other issues in our react repo (outside the a11y ones you've picked up, which awesome job for taking those on) we can try to find some issues that might be a good fit (some of our issues might be goof first issues, we just haven't applied the label to them).

I am currently exploring small issues which I happen to understand. It would be great help if you guys can help me figure issues on which I can work. I did join the mailing list to look out for upcoming community meetings.
Thank You !!!

@Mash707
Copy link
Contributor

Mash707 commented Mar 4, 2025

@types/node - Current: 20.17.16 | Latest: 2.12.0 | Depended by: patternfly-react

@thatblindgeye are we referring the version 22.12.0?

@thatblindgeye
Copy link
Contributor Author

@Mash707 yes it should be 22.12.0, I'll update the original comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready to assign
Development

No branches or pull requests

2 participants