Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and Drop: Feature request for DragHandler support #6982

Closed
Tracked by #6317
christoph-jerolimov opened this issue Feb 28, 2022 · 3 comments
Closed
Tracked by #6317

Drag and Drop: Feature request for DragHandler support #6982

christoph-jerolimov opened this issue Feb 28, 2022 · 3 comments
Assignees
Labels

Comments

@christoph-jerolimov
Copy link
Contributor

christoph-jerolimov commented Feb 28, 2022

Describe the issue. What is the expected and unexpected behavior?
Based on your documentation https://patternfly-react.surge.sh/components/drag-and-drop/ and the code of the Drag n Drop code https://github.com/patternfly/patternfly-react/tree/main/packages/react-core/src/components/DragDrop I miss a feature other D&D libraries are calling "Drag Handler".

In your basic example, you show how to implement a reorderable list with the components DragDrop, Droppable and Draggable.

But sometimes it is required that just a sub-component is "moveable" (which means not the complete Draggable child).

For example, when using input fields, this doesn't allow the user to select their input anymore:

Peek 2022-02-28 10-23

A common pattern to fix this is adding a "DragHandler" only to a part of the child elements so that the user can drag the complete element only there. For example:

Peek 2022-02-28 10-27

Please provide the steps to reproduce. Feel free to link CodeSandbox or another tool.
https://codesandbox.io/s/patternfly-drag-and-drop-missed-draghandler-0h03tx

Is this a bug or enhancement? If this issue is a bug, is this issue blocking you or is there a work-around?
Enhancement / feature request

What is your product and what release version are you targeting?
OpenShift console

@tlabaj
Copy link
Contributor

tlabaj commented Mar 11, 2022

cc @nicolethoen

@nicolethoen nicolethoen self-assigned this Mar 11, 2022
@mcarrano mcarrano added this to the 2022.05 milestone Mar 11, 2022
@mcarrano mcarrano modified the milestones: 2022.05, 2022.06, 2022.07 Apr 18, 2022
@mcarrano mcarrano modified the milestones: 2022.07, 2022.08 May 27, 2022
@mcarrano mcarrano modified the milestones: 2022.08, 2022.10 Jun 17, 2022
@mcarrano mcarrano modified the milestones: 2022.10, 2022.11 Jul 29, 2022
@mcarrano mcarrano removed this from the 2022.11 milestone Aug 19, 2022
@stale
Copy link

stale bot commented Oct 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Oct 18, 2022
@stale stale bot closed this as completed Nov 3, 2022
@nicolethoen nicolethoen reopened this Nov 4, 2022
@stale
Copy link

stale bot commented Jan 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 3, 2023
@stale stale bot closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants