Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popper - remove ToggleMenuBaseProps #7438

Closed
jenny-s51 opened this issue May 18, 2022 · 2 comments · Fixed by #8235
Closed

Popper - remove ToggleMenuBaseProps #7438

jenny-s51 opened this issue May 18, 2022 · 2 comments · Fixed by #8235
Assignees
@jenny-s51
Labels
Breaking change 💥 this change requires a major release and has API changes. PF5
Milestone
2022.15

Comments

@jenny-s51
Copy link
Contributor

jenny-s51 commented May 18, 2022 •
edited
Loading

Is this a new component or an extension of an existing one?
What is the existing component, if any?
Extends #6985

Describe the feature
Remove deprecated prop interface ToggleMenuBaseProps from Popper and from the components which extend this interface.
@jenny-s51 jenny-s51 added Breaking change 💥 this change requires a major release and has API changes. needs triage labels May 18, 2022
@jenny-s51 jenny-s51 changed the title [Popper] - [remove ToggleMenuBaseProps] Popper - remove ToggleMenuBaseProps May 18, 2022
@jenny-s51 jenny-s51 mentioned this issue May 18, 2022
Merged
@mcarrano mcarrano added this to the Breaking Changes milestone May 31, 2022
@nicolethoen nicolethoen moved this to Breaking change in PatternFly Issues Jul 19, 2022
@tlabaj tlabaj modified the milestones: Breaking Changes, 2022.15 Sep 27, 2022
@nicolethoen nicolethoen moved this from Breaking change to Not started in PatternFly Issues Oct 5, 2022
@jenny-s51 jenny-s51 self-assigned this Oct 13, 2022
@jenny-s51
Copy link
Contributor Author

jenny-s51 commented Oct 13, 2022 •
edited
Loading

Picking this up again for the upcoming breaking change release @tlabaj ! I had initially worked on this issue and put up the PR for a non-breaking workaround earlier this year

@jenny-s51 jenny-s51 mentioned this issue Oct 14, 2022
Merged
@jenny-s51 jenny-s51 moved this from Not started to PR Review in PatternFly Issues Oct 14, 2022
@nicolethoen
Copy link
Contributor

Closed by #8235

Repository owner moved this from PR Review to Done in PatternFly Issues Oct 17, 2022
@nicolethoen nicolethoen added the PF5 label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jenny-s51 jenny-s51

Labels
Breaking change 💥 this change requires a major release and has API changes. PF5
Projects
PatternFly Issues
Archived in project
Milestone
2022.15
Development

Successfully merging a pull request may close this issue.

Removed deprecated prop interface ToggleMenuBaseProps jenny-s51/patternfly-react
4 participants
@mcarrano @nicolethoen @jenny-s51 @tlabaj