Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug -DataList - drag drop results in error #7637

Closed
Tracked by #6317
edewit opened this issue Jun 30, 2022 · 2 comments
Closed
Tracked by #6317

Bug -DataList - drag drop results in error #7637

edewit opened this issue Jun 30, 2022 · 2 comments
Assignees

Comments

@edewit
Copy link
Contributor

edewit commented Jun 30, 2022

Describe the problem
DataList drag and drop no longer works but gives error:

Truncate-a84c533a.js:3996 Uncaught TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.
    at Truncate-a84c533a.js:3996:24
    at Array.forEach (<anonymous>)
    at DataList.move (Truncate-a84c533a.js:3995:23)
    at DataList.dragOver0 (Truncate-a84c533a.js:4072:22)
    at DataList.dragOver (Truncate-a84c533a.js:4087:22)
    at HTMLUnknownElement.callCallback (react-dom.v17.0.2.js:3952:14)
    at Object.invokeGuardedCallbackDev (react-dom.v17.0.2.js:4001:16)
    at invokeGuardedCallback (react-dom.v17.0.2.js:4063:31)
    at invokeGuardedCallbackAndCatchFirstError (react-dom.v17.0.2.js:4077:25)
    at executeDispatch (react-dom.v17.0.2.js:8250:3)

How do you reproduce the problem?
When you drop the item that has been dragged it results in error above see codesandbox:

https://codesandbox.io/s/focused-water-soey9j?file=/index.js

Expected behavior
No error ;)

Is this issue blocking you?
No we can update to the new beta feature: https://www.patternfly.org/v4/components/data-list#draggable

@edewit edewit changed the title Bug - [Component] - [short description] Bug -DataList - drag drop results in error Jun 30, 2022
@nicolethoen
Copy link
Contributor

@edewit I believe the props used to implement the drag and drop feature of the data list is deprecated.
In fact we are in the process of further updating and enhancing our implementation of the beta DragDrop component used in the beta example you referenced. You can follow that effort in the issue linked above.
But I don't believe we will be making any changes to the deprecated features of the DataList component.

@stale
Copy link

stale bot commented Sep 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Sep 18, 2022
@stale stale bot closed this as completed Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants