Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] - [add ouiaId properties to WizardNav, WizardNavITem, ClipboardCopy and the Modal close icon] #7767

Closed
gashcrumb opened this issue Jul 28, 2022 · 5 comments · Fixed by #8193
Assignees
Milestone

Comments

@gashcrumb
Copy link

There's a few elements that we would like add tags to for user tracking and automation, however there's a few React components that don't appear to offer properties to set a customized ID. It'd be great if these 3 components offered a ouiaId property:

  • WizardNav
  • WizardNavItem
  • ClipboardCopy

Additionally while the Modal component does accept a custom automation ID however the close icon uses a generated ID. It'd be nice if there was a way to either specify the OUIA ID for the Modal close icon or if the Modal component could perhaps use value built off of the ouiaId property it receives.

@mcarrano
Copy link
Member

mcarrano commented Aug 1, 2022

@tlabaj can you take a look at this one?

@mcarrano mcarrano added this to the 2022.13 milestone Aug 10, 2022
@tlabaj
Copy link
Contributor

tlabaj commented Aug 11, 2022

Hi @gashcrumb traditionally the QE team has added the ouiaId they need for automation. Would your team be able to add the IDs you need.

@nicolethoen nicolethoen moved this to Not started in PatternFly Issues Aug 16, 2022
@gashcrumb
Copy link
Author

Yep, one option is I could come up with some generic IDs that are always set on these components, that'd probably work. I was looking more to update the interface for these components so that we could control the values used at the application layer as the plan is also to use this facility for user tracking as well. I'll have to investigate if I can come up with a convention using static ids that would satisfy that need.

@jschuler
Copy link
Collaborator

jschuler commented Sep 2, 2022

I think @tlabaj meant that the QE team would update the code to enable OUIA IDs. If you have team members that would like to contribute those changes to PatternFly that would be a way to go about it, or we can open up the issue to the wider team/community.

@tlabaj
Copy link
Contributor

tlabaj commented Sep 2, 2022

Thank you at @jschuler. Yes that is what I meant.

@mcarrano mcarrano modified the milestones: 2022.13, 2022.14 Sep 2, 2022
@kmcfaul kmcfaul moved this from Not started to In Progress in PatternFly Issues Oct 10, 2022
@kmcfaul kmcfaul moved this from In Progress to PR Review in PatternFly Issues Oct 12, 2022
Repository owner moved this from PR Review to Done in PatternFly Issues Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
5 participants