Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Dropdown - position='right' does not work in combination with isFlipEnabled #8013

Closed
wise-king-sullyman opened this issue Sep 19, 2022 · 0 comments · Fixed by #8224
Closed

Bug - Dropdown - position='right' does not work in combination with isFlipEnabled #8013

wise-king-sullyman opened this issue Sep 19, 2022 · 0 comments · Fixed by #8224
Assignees
@wise-king-sullyman
Milestone
2022.14

Comments

@wise-king-sullyman
Copy link
Contributor

Describe the problem
Enabling flip behavior on the Dropdown component causes the menu to only render left-aligned with the toggle, regardless of the setting of the position prop.

How do you reproduce the problem?
Set position='right' and isFlipEnabled={true}` on a Dropdown.
https://codesandbox.io/s/pedantic-ben-j8l5wg?file=/index.tsx

Screenshots
image

It seems that this issue is (at least partially) caused by position: revert being applied when flipping is enabled.
@SanjalKatiyar SanjalKatiyar mentioned this issue Sep 20, 2022
Merged
@mcarrano mcarrano added this to the 2022.14 milestone Sep 20, 2022
@wise-king-sullyman wise-king-sullyman moved this to Not started in PatternFly Issues Oct 5, 2022
@wise-king-sullyman wise-king-sullyman moved this from Not started to In Progress in PatternFly Issues Oct 11, 2022
@wise-king-sullyman wise-king-sullyman mentioned this issue Oct 13, 2022
Merged
@wise-king-sullyman wise-king-sullyman moved this from In Progress to PR Review in PatternFly Issues Oct 13, 2022
Repository owner moved this from PR Review to Done in PatternFly Issues Oct 18, 2022
@tthvo tthvo mentioned this issue Oct 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wise-king-sullyman wise-king-sullyman

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
2022.14
Development

Successfully merging a pull request may close this issue.

fix(Dropdown): enabled right aligned dropdown with isFlipEnabled wise-king-sullyman/patternfly-react
2 participants
@mcarrano @wise-king-sullyman