Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Chip - tooltip not shown when under Expandable section or similar #9690

Closed
celdrake opened this issue Sep 27, 2023 · 1 comment · Fixed by #9819
Closed

Bug - Chip - tooltip not shown when under Expandable section or similar #9690

celdrake opened this issue Sep 27, 2023 · 1 comment · Fixed by #9819
Assignees
Milestone

Comments

@celdrake
Copy link

Describe the problem
The Chip component determines if it needs to show a tooltip (to be seen when the text is very long), at the moment that it's mounted.

When combined with a component such as a Expandable section, the result is that the tooltip won't be shown even for very long text.

How do you reproduce the problem?
See the sandbox. The second section demonstrates the problem.
https://codesandbox.io/s/pensive-wescoff-t46t3r?file=/index.js

Expected behavior
For a long text, the tooltip should be displayed, no matter if the component is initially hidden or not.
If it cannot be controlled, maybe provide a property that can be passed so that consuming apps can force the tooltip for certain text lengths, etc.

Is this issue blocking you?
No, if necessary we'll try to figure out a workaround.

Video
See the video demonstrating what can be seen in the provided Sandbox.
https://github.com/patternfly/patternfly-react/assets/829045/fc146765-c5bc-4649-9f31-64c9319166c2

What is your environment?
We use Patternfly v4, but the Sandbox is v5.0.1 and the same problem appears as well.
In both cases, I see that the same strategy of using componentDidMount is used in the Chip component.

  • Browser: the issue is present equally with Chrome and Firefox.
@celdrake celdrake added the bug label Sep 27, 2023
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Sep 27, 2023
@wise-king-sullyman wise-king-sullyman added this to the Prioritized Backlog milestone Oct 6, 2023
@wise-king-sullyman wise-king-sullyman moved this from Needs triage to Backlog in PatternFly Issues Oct 6, 2023
@wise-king-sullyman wise-king-sullyman moved this from Backlog to Not started in PatternFly Issues Oct 27, 2023
@thatblindgeye thatblindgeye moved this from Not started to In Progress in PatternFly Issues Nov 9, 2023
@wise-king-sullyman wise-king-sullyman moved this from In Progress to PR Review in PatternFly Issues Nov 13, 2023
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Nov 16, 2023
@celdrake
Copy link
Author

Thanks for the quick response and fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants