Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Chip - duplicate id gets rendered #9764

Closed
thatblindgeye opened this issue Oct 19, 2023 · 0 comments · Fixed by #9886
Closed

Bug - Chip - duplicate id gets rendered #9764

thatblindgeye opened this issue Oct 19, 2023 · 0 comments · Fixed by #9886
Assignees
@thatblindgeye
Milestone
2023.Q4

Comments

@thatblindgeye
Copy link
Contributor

Describe the problem
Followup based on comment chain #9572 (comment)

tldr: the same id gets rendered twice within Chip if the prop is manually passed in, e.g. <Chip id="tester"> will render the "tester" id on the top pf-v-5-chip element and the pf-v5-c-chip__text element.
@thatblindgeye thatblindgeye self-assigned this Oct 19, 2023
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Oct 19, 2023
@thatblindgeye thatblindgeye mentioned this issue Oct 19, 2023
Merged
@wise-king-sullyman wise-king-sullyman moved this from Needs triage to Backlog in PatternFly Issues Oct 27, 2023
@tlabaj tlabaj modified the milestones: Prioritized Backlog, 2023.Q4 Nov 9, 2023
@thatblindgeye thatblindgeye moved this from Backlog to Not started in PatternFly Issues Dec 6, 2023
@thatblindgeye thatblindgeye mentioned this issue Dec 13, 2023
Merged
@thatblindgeye thatblindgeye moved this from Not started to PR Review in PatternFly Issues Dec 13, 2023
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
2023.Q4
Development

Successfully merging a pull request may close this issue.

fix(Chip): prevented duplicate ID being applied thatblindgeye/patternfly-react
3 participants
@wise-king-sullyman @tlabaj @thatblindgeye