Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume core Penta updates: Divider #9919

Closed
Tracked by #9879
tlabaj opened this issue Jan 2, 2024 · 2 comments · Fixed by #10081
Closed
Tracked by #9879

Consume core Penta updates: Divider #9919

tlabaj opened this issue Jan 2, 2024 · 2 comments · Fixed by #10081
Assignees
@kmcfaul
Milestone
Penta alpha release

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Jan 2, 2024 •
edited
Loading

follow up to core issue patternfly/patternfly#6136
@tlabaj tlabaj mentioned this issue Jan 2, 2024
Closed
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jan 2, 2024
@tlabaj tlabaj added PF6 labels Jan 2, 2024
@tlabaj tlabaj moved this from Needs triage to On deck in PatternFly Issues Jan 2, 2024
@tlabaj tlabaj added this to the 2024.Q1 milestone Jan 2, 2024
@wise-king-sullyman wise-king-sullyman moved this from On deck to Not started in PatternFly Issues Jan 3, 2024
@kmcfaul kmcfaul moved this from Not started to In Progress in PatternFly Issues Jan 9, 2024
@kmcfaul
Copy link
Contributor

kmcfaul commented Jan 15, 2024

Horizontal divider needs no changes.
Vertical divider needs a core fix (not displaying in a flex layout on react examples and core examples).

Keeping issue open for now until core update with the fix goes in.

@mcoker mcoker mentioned this issue Jan 31, 2024
Closed
@mcoker
Copy link
Contributor

mcoker commented Feb 9, 2024

@kmcfaul @tlabaj this should be fixed in core, we added an example of the divider in a flex layout here - https://pf6.patternfly.org/components/divider#in-flex-layout

@kmcfaul kmcfaul mentioned this issue Feb 13, 2024
Merged
@kmcfaul kmcfaul linked a pull request Feb 13, 2024 that will close this issue
feat(CodeEditor,Divider): consume penta & update core version #10081
Merged
@kmcfaul kmcfaul moved this from In Progress to PR Review in PatternFly Issues Feb 13, 2024
@kmcfaul kmcfaul closed this as completed Feb 19, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmcfaul kmcfaul

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
Penta alpha release
Development

Successfully merging a pull request may close this issue.

feat(CodeEditor,Divider): consume penta & update core version kmcfaul/patternfly-react
4 participants
@wise-king-sullyman @mcoker @tlabaj @kmcfaul