Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume core Penta updates: Card #9991

Closed
Tracked by #9990
tlabaj opened this issue Jan 16, 2024 · 1 comment · Fixed by #10056
Closed
Tracked by #9990

Consume core Penta updates: Card #9991

tlabaj opened this issue Jan 16, 2024 · 1 comment · Fixed by #10056
Assignees
@tlabaj
Milestone
Penta alpha release

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Jan 16, 2024 •
edited
Loading

Follow up to core issue patternfly/patternfly#6186

The following was done with core bump PR #10017

  • disabled logic for raised variants in getSelectableModifiers
  • removed application of isRounded modifier
  • removed application of isFlat modifier
  • disabled som unit test
  • removed isRounded and isFlat from modifier example
  • disabled failing integration test
@tlabaj tlabaj mentioned this issue Jan 16, 2024
Closed
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jan 16, 2024
@tlabaj tlabaj moved this from Needs triage to On deck in PatternFly Issues Jan 16, 2024
@tlabaj tlabaj added this to the 2024.Q1 milestone Jan 16, 2024
@wise-king-sullyman wise-king-sullyman moved this from On deck to Not started in PatternFly Issues Jan 17, 2024
@tlabaj tlabaj mentioned this issue Jan 18, 2024
Merged
@wise-king-sullyman wise-king-sullyman moved this from Not started to In Progress in PatternFly Issues Jan 31, 2024
@tlabaj tlabaj mentioned this issue Jan 31, 2024
Merged
@tlabaj tlabaj linked a pull request Feb 2, 2024 that will close this issue
feat(Card): Consume penta tokens #10056
Merged
@wise-king-sullyman wise-king-sullyman moved this from In Progress to PR Review in PatternFly Issues Feb 8, 2024
@tlabaj
Copy link
Contributor Author

tlabaj commented Feb 13, 2024

Closed by #10056

@tlabaj tlabaj closed this as completed Feb 13, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlabaj tlabaj

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
Penta alpha release
Development

Successfully merging a pull request may close this issue.

feat(Card): Consume penta tokens tlabaj/patternfly-react
2 participants
@wise-king-sullyman @tlabaj