Skip to content

Commit f5ea9a0

Browse files
committed
feat(Checkbox/Radio): replace isLabelBeforeButton with labelPosition="start"
1 parent 1ded4ca commit f5ea9a0

File tree

5 files changed

+79
-0
lines changed

5 files changed

+79
-0
lines changed
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
### checkbox-radio-replace-isLabelBeforeButton [(#10016)](https://github.com/patternfly/patternfly-react/pull/10016)
2+
3+
The `isLabelBeforeButton` prop in Checkbox and Radio has been replaced with `labelPosition="start"`
4+
5+
#### Examples
6+
7+
In:
8+
9+
```jsx
10+
%inputExample%
11+
```
12+
13+
Out:
14+
15+
```jsx
16+
%outputExample%
17+
```
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
const ruleTester = require("../../ruletester");
2+
import * as rule from "./checkbox-radio-replace-isLabelBeforeButton";
3+
4+
ruleTester.run("checkbox-radio-replace-isLabelBeforeButton", rule, {
5+
valid: [
6+
{
7+
code: `<Checkbox isLabelBeforeButton />`,
8+
},
9+
{
10+
code: `import { Checkbox } from '@patternfly/react-core'; <Checkbox someOtherProp />`,
11+
},
12+
{
13+
code: `<Radio isLabelBeforeButton />`,
14+
},
15+
{
16+
code: `import { Radio } from '@patternfly/react-core'; <Radio someOtherProp />`,
17+
},
18+
],
19+
invalid: ["Checkbox", "Radio"].map((component) => ({
20+
code: `import { ${component} } from '@patternfly/react-core'; <${component} isLabelBeforeButton />`,
21+
output: `import { ${component} } from '@patternfly/react-core'; <${component} labelPosition="start" />`,
22+
errors: [
23+
{
24+
message: `isLabelBeforeButton prop for ${component} has been replaced with labelPosition="start"`,
25+
type: "JSXOpeningElement",
26+
},
27+
],
28+
})),
29+
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
import { renameProps } from "../../helpers";
2+
3+
const renames = {
4+
isLabelBeforeButton: {
5+
newName: 'labelPosition="start"',
6+
replace: true,
7+
},
8+
};
9+
10+
// https://github.com/patternfly/patternfly-react/pull/10016
11+
module.exports = {
12+
meta: { fixable: "code" },
13+
create: renameProps({
14+
Checkbox: renames,
15+
Radio: renames,
16+
}),
17+
};
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import { Checkbox, Radio } from "@patternfly/react-core";
2+
3+
export const CheckboxReplaceIsLabelBeforeButtonInput = () => (
4+
<Checkbox isLabelBeforeButton />
5+
);
6+
export const RadioReplaceIsLabelBeforeButtonInput = () => (
7+
<Radio isLabelBeforeButton />
8+
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import { Checkbox, Radio } from "@patternfly/react-core";
2+
3+
export const CheckboxReplaceIsLabelBeforeButtonInput = () => (
4+
<Checkbox labelPosition="start" />
5+
);
6+
export const RadioReplaceIsLabelBeforeButtonInput = () => (
7+
<Radio labelPosition="start" />
8+
);

0 commit comments

Comments
 (0)