Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wizard/Wizard next - button order updated #164

Closed
nicolethoen opened this issue Dec 8, 2022 · 0 comments · Fixed by #215
Closed

Wizard/Wizard next - button order updated #164

nicolethoen opened this issue Dec 8, 2022 · 0 comments · Fixed by #215
Assignees
@thatblindgeye
Labels
codemod pf5 codemod for p4 to p5 transition
Milestone
2023.01

Comments

@nicolethoen
Copy link
Contributor

Follow up to breaking change PR patternfly/patternfly-react#8409

Likely we might only be able to warn consumers of the wizard/wizard next components that the buttons in the WizardFooter/InternalWizardFooter have had their order updated for the sake of updating their composable implementations and/or relative selectors in unit/integration tests.

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@nicolethoen nicolethoen moved this to Not started in PatternFly Issues Dec 12, 2022
@nicolethoen nicolethoen added this to the 2023.01 milestone Dec 21, 2022
@thatblindgeye thatblindgeye self-assigned this Jan 19, 2023
@thatblindgeye thatblindgeye mentioned this issue Jan 19, 2023
Merged
@thatblindgeye thatblindgeye moved this from Not started to PR Review in PatternFly Issues Jan 19, 2023
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jan 20, 2023
@gitdallas gitdallas added the pf5 codemod for p4 to p5 transition label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
codemod pf5 codemod for p4 to p5 transition
Projects
PatternFly Issues
Archived in project
Milestone
2023.01
Development

Successfully merging a pull request may close this issue.

feat(Wizard): updated button order thatblindgeye/pf-codemods
3 participants
@gitdallas @nicolethoen @thatblindgeye